On 2005.03.01, Tom Jackson <[EMAIL PROTECTED]> wrote: > > Okay, I have taken the time to browse several source files. I think > the cleanest I have found is binder.c, but it still has several > styles, or inconsistencies. I'm talking only about whitespace here, > not any of the naming conventions, or broader considerations.
Indeed, there's places in the codebase where hard tabs still exist. They should be replaced with 4 spaces where appropriate, but only when you're actually touching that portion of the code to fix a bug or change functionality. > So I'm really stuck wondering what to do. The source files differ in > substantial ways from the written guides. The source files differ from > each other, and each file itself represents several styles. Stick with what's in the published AOLserver Engineering Manual's style guide. If/when you touch code that doesn't comply, then only then make the necessary changes to make it do so. > I had the timely fortune of needing to replace my crashed hard drive > this weekend and I noticed a program being installed called 'indent'. > Indent is a program which reformats the whitespace of C source code. > Given a series of switches, which can be maintained in a file, it can > help developers transform the files they are working on into a > consistent style. It seems to have enough switches to handle more than > has ever been covered in either of the written guides. GNU indent is cool, but not being maintained and it's really geared to the "GNU C" style which sucks (unless you're am Emacs person, in which case, you're already used to seeing that ugliness if you use its c-mode). If you want to try, go ahead and try to come up with the necessary command line switches for GNU indent that will format AOLserver source to conform to the currently published style guide. If it's possible, then this might be worth documenting on the wiki, what command line options are appropriate, and perhaps include it in the style guide itself. > I'm sure there are downsides, but it sounds like a good way to > document one small aspect of the development standards for AOLserver. > > Has anyone had good or bad experiences with this tool? I wouldn't say "bad" but I definitely had to extend GNU indent when I was using it and I tried to find a maintainer to submit patches to and the last known maintainer never responded to me -- not even to tell me that he wasn't accepting patches. -- Dossy -- Dossy Shiobara mail: [EMAIL PROTECTED] Panoptic Computer Network web: http://www.panoptic.com/ "He realized the fastest way to change is to laugh at your own folly -- then you can let go and quickly move on." (p. 70) -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
