On 21/08/2008, at 1:45 AM, Jim Davidson wrote:

I looked at the code a bit closer. The ns_returnfile and ns_respond commands both call Ns_ConnReturnFile, the public API to the underlying FastPath. It does more than just blast the content -- it handles:

...
-- caches, mmap's, or simply opens the fd and sends, chunk by chunk

not directly related to the issue at hand, but if this is being worked on shouldn't the file returning be handled by sendfile() on platforms that support it? that'd bypass fastpath, but on linux at least you'd not be wasting RAM by buffering in both the page cache and fastpath, and spitting the data back out the connection socket gets handled entirely in the kernel...

just a thought...


cheers

Russell


--
AOLserver - http://www.aolserver.com/

To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> 
with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: 
field of your email blank.

Reply via email to