On Thu, Mar 26, 2009 at 1:40 PM, Dossy Shiobara <[email protected]> wrote:
> I wonder - should this be the documented known behavior of ns_adp_abort vs.
> ns_adp_return?  i.e., abort indicates that the connection is intentionally
> terminated, not logged, etc. vs. ns_adp_return which halts ADP processing
> but continues the connection, which includes logging, etc.

We have some ADP code that explicitly returns data via ns_return and
then calls ns_adp_abort to discontinue processing.  It isn't an error
per se, just another way of getting data back to the client.  Maybe
it's a pathological case.  I don't understand exactly why we do it
that way (not my code), but the ns_adp_abort documentation mentions
this type of strategy.

> I'm inclined to agree with you that the current behavior is a bug, but it
> raises the question: should there be such a function that says "this
> connection wasn't handled, don't even log it" - or, should ALL connections
> always be logged, even if it's aborted?

As Scott suggested, we should probably log everything, at least for
some reasonable value of "everything."  Even if you switch the access
log trace to the cleanup callback, you still don't get access entries
for clients who connect but don't issue a well formed HTTP request.  I
don't have a huge problem with that, and I think it would be difficult
to log those types of events.


--
AOLserver - http://www.aolserver.com/

To Remove yourself from this list, simply send an email to 
<[email protected]> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: 
field of your email blank.

Reply via email to