From: "Cliff Woolley" <[EMAIL PROTECTED]> Sent: Monday, August 20, 2001 5:24 PM
> On Mon, 20 Aug 2001, William A. Rowe, Jr. wrote: > > > Be very careful that the Body: tag matches the ending tag. The > > commit of my mod_negotiation patch included diagnostics. We will only > > parse 8k bytes, all these files were smaller than 1k. > > > > Does this look good to everyone? Very fast, very compact, very > > consistent. > > Forgive me if I missed part of this conversation... I'm only about 30% > done reading the 1100+ emails I missed last week. > > I like it, except for a few nits with the Body: thing. (1), why no space > after the : and before the separator? Granted, we're not making a *real* > header, but it just looks funny and is inconsistent. Allowed. Not required. Comments are allowed in the tag line, as well. > (2), why in > Content-type and Content-language are the 't' and 'l' lower-case? Just because (it's case insensitive). Feel free to grep and commit a fix, if that nit bugs you :) > (3), why not use multipart/alternative syntax rather than inventing our own? > Something like the following. Because it would be a radical restructuring of type-map files, instead of a late addition. Martin suggests we go with what you describe (or similar), and I'm prone to agree. But I didn't have time to write the lexical parser (or find one under apache license) this week. > Thoughts? Anybody who wants to fix mod_negotation to recognize this, great! We can depricate the body tag (and eliminate it if we haven't gone GA.) I'm actually thinking (as I mentioned in another note) that all these results should land in a config tree, as our conf parser would do. But that's another project, entirely ;) [and I don't want mod_negotiation to grow that much, it needs refactoring into multiple source files as things stand today!] Bill > ----------------------------------------------------------------------- > Content-Type: multipart/alternative; boundary="------------foo" > > > ------------foo > Content-Type: text/html > Content-Language: en > > blah blah blah > > ------------foo > Content-Type: text/html > Content-Language: es > > bleh bleh bleh > > ------------foo > > ---------------------------------------------------------------------- > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
