On Fri, Aug 12, 2016 at 10:57:08PM +0200, Christian Boltz wrote:
> this patch adds the glob() and glob_ext() functions to FileRule, and sets
> self.can_glob and self.can_glob_ext. Also add some tests (just enough to
> make sure the FileRule integration works - the globbing is handled
> inside AARE,and the AARE tests contain more testcases).

Can you add a comment to this effect in the FileGlobTest class, that
it's purpose is to ensure the FileRule integration works, and a pointer
to the more comprehensive regex tests in test-aare.py?

> Note that the implementation differs from the original plan (which was
> to have globbing in *Ruleset). Therefore add can_glob and can_glob_ext
> to BaseRule (both default to False), and add a comment to BaseRuleset
> that globbing needs to be removed from all *Ruleset classes.

Okay.

> [ 17-FileRule-implement-globbing.diff ]

Otherwise, looks fine. Acked-by: Steve Beattie <st...@nxnw.org>. Thanks!

-- 
Steve Beattie
<sbeat...@ubuntu.com>
http://NxNW.org/~steve/

Attachment: signature.asc
Description: PGP signature

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to