Hello,

Am Donnerstag, 22. September 2016, 12:37:22 CEST schrieb Steve Beattie:
> On Fri, Aug 12, 2016 at 10:57:08PM +0200, Christian Boltz wrote:
> > this patch adds the glob() and glob_ext() functions to FileRule, and
> > sets self.can_glob and self.can_glob_ext. Also add some tests (just
> > enough to make sure the FileRule integration works - the globbing
> > is handled inside AARE,and the AARE tests contain more testcases).
> 
> Can you add a comment to this effect in the FileGlobTest class, that
> it's purpose is to ensure the FileRule integration works, and a
> pointer to the more comprehensive regex tests in test-aare.py?

Good idea, I'll add that comment before commiting.

> > Note that the implementation differs from the original plan (which
> > was to have globbing in *Ruleset). Therefore add can_glob and
> > can_glob_ext to BaseRule (both default to False), and add a comment
> > to BaseRuleset that globbing needs to be removed from all *Ruleset
> > classes.
> Okay.
> 
> > [ 17-FileRule-implement-globbing.diff ]
> 
> Otherwise, looks fine. Acked-by: Steve Beattie <st...@nxnw.org>.
> Thanks!
Regards,

Christian Boltz
-- 
> copy+paste zusammen gesetzt. Naja, er hat Stein und Bein geschworen
> das schon öfter so gemacht zu haben, erfolgreich versteht sich, drum
Logisch. Selbstverständlich.
Und Du bist der ALLEROBEREINZIGSTE Mailserver auf der ganzen Welt wo es
nicht geht -- und das ist ja nun wirklich unverschämt von Dir.
[Robert Stark und Peer Heinlein in postfixbuch-users]

Attachment: signature.asc
Description: This is a digitally signed message part.

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to