On 4 February 2014 01:27, Manuel A. Fernandez Montecelo <[email protected]> wrote: > 2014-02-03 Manuel A. Fernandez Montecelo <[email protected]>: >> 2014-02-03 Daniel Hartwig <[email protected]>: >>> On 3 February 2014 23:58, Manuel A. Fernandez Montecelo >>> <[email protected]> wrote: >>>> 2014-02-03 Daniel Hartwig <[email protected]>: >>>>> Duplicates are not desirable, even if it resolves the issue with >>>>> missing packages. Anyway, lets just have it reverted and fixed on >>>>> wip-cmdline (weeks now, see below). >>>> >>>> It was a joke, that if one puts the terms twice, having duplicated >>>> output might be the intended behaviour. >>>> >>>> I agree that this the current solution is not good in the case of >>>> overlaps (or well, trades one bug for one undesired behaviour or bug, >>>> depending on the point of view). >>>> >>> >>> Trading one bug for another obvious bug is unacceptable on master. >>> Likewise, with the initial version of "installsizechange" being >>> obviously broken in the context of the rest of the module. >>> >>> You must be more thorough with your work. These kinds of "quick fix" >>> are unsuitable for applying to the master branch. >>> >>>> So I will fix this within a couple of days, no problem. >>>> >>>> >>> >>> In the future, please submit your work as patches or prepare changes >>> on a separate branch for review. >> >> >> NACK. And I already fixed bugs introduced by yourself in the last >> releases and present for many months, so please don't be so cocky. >> >> I was joking anyway, and the previous bug was present for 4 years, so >> living a few days in master is not the end of the world. > > With the bug present for 4 years I mean: *almost all* of the sorting > policies were broken by the previous, so my investigations and patches > already helped to uncover them. > > Not exactly useless my changes :-) >
I do not suggest they are useless. Just not of a quality suitable for release. You knew about the issues with these changes and you committed them anyway, that is unacceptable. Submit your work for review before committing to master. > -- > Manuel A. Fernandez Montecelo <[email protected]> _______________________________________________ Aptitude-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/aptitude-devel
