Hi David,

David Reiser schrieb:
It doesn't seem like this should be the right solution in general, but it allows me to build qbankmanager with gcc 4.0.1 from Apple:

good to know. However this change cannot be used in general. On Linux the iconv(3) function is declared with two "char**" pointers. Obviously on your system the first pointer is declared a "const char **". The correct solution would be to make the declaration of pInbuf depending on the available declaration of iconv(3)...

But since qbankmanager is a qt-based application anyway, we should probably rather get rid of using iconv() and instead use QString::fromUtf8() and similar.

@Martin: I understand that you intentionally don't use anything QT-specific in app.h/cpp, which is fine. *But*: The whole App__convertFromUtf8() function is used *only* from App_FuzzyCompare(), which in turn (including its other helper functions) doesn't even depend on anything else within the "App" class. I'd strongly recommend that the whole App_FuzzyCompare() function should be moved from the app.h/cpp files into somewhere else where you can directly use the QString class and remove the iconv() function. The whole iconv() stuff is a crufty solution from the old days when there wasn't a portable solution available at all. Nowadays it's just much easier to use the QString functions, which will give you the portability for free, instead of having to deal with different iconv() declarations...


Index: kde/src/kbanking/libs/prg/app.cpp
===================================================================
RCS file: /cvsroot/aqbanking/bindings/kde/src/kbanking/libs/prg/ app.cpp,v
retrieving revision 1.53
diff -u -r1.53 app.cpp
--- kde/src/kbanking/libs/prg/app.cpp 17 Jan 2006 22:32:57 -0000 1.53
+++ kde/src/kbanking/libs/prg/app.cpp   1 Feb 2006 08:11:02 -0000
@@ -2675,7 +2675,7 @@
   else {
     char *outbuf;
     char *pOutbuf;
-    char *pInbuf;
+    const char *pInbuf;
     size_t inLeft;
     size_t outLeft;
     size_t done;


I still have the socket not connecting problem, but maybe it will be easier to debug without gnucash involved.




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Aqbanking-devel mailing list
Aqbanking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/aqbanking-devel

Reply via email to