Hi, On Wednesday 01 February 2006 09:54, Christian Stimming wrote: [...] > But since qbankmanager is a qt-based application anyway, we should > probably rather get rid of using iconv() and instead use > QString::fromUtf8() and similar. > > @Martin: I understand that you intentionally don't use anything > QT-specific in app.h/cpp, which is fine. *But*: The whole > App__convertFromUtf8() function is used *only* from App_FuzzyCompare(), > which in turn (including its other helper functions) doesn't even depend > on anything else within the "App" class. I'd strongly recommend that the > whole App_FuzzyCompare() function should be moved from the app.h/cpp > files into somewhere else where you can directly use the QString class > and remove the iconv() function. The whole iconv() stuff is a crufty > solution from the old days when there wasn't a portable solution > available at all. Nowadays it's just much easier to use the QString > functions, which will give you the portability for free, instead of > having to deal with different iconv() declarations... [...]
We could disable that function for now, but I don't want to move it. Currently it is not used, but I plan to maybe use it in the transaction matcher code (which is in app.cpp, so it will depend on that code being within that folder). Please don't move it... It would be better to check for the needed type and use it correctly, but since we currently don't use that function we could as well envelope it with a "#if 0 .. #endif". Regards Martin -- "Things are only impossible until they're not" AqBanking - http://www.aquamaniac.de/aqbanking/ LibChipcard - http://www.libchipcard.de/ ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Aqbanking-devel mailing list Aqbanking-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/aqbanking-devel
