Am Samstag, 17. Februar 2007 18:22 schrieb Martin Preuss:
> > in gwen there is still one more place with the everlasting topic of
> > windows directory separators: In src/parser/path.c the function
> > GWEN_Path_Convert by means of GWEN_Path_AppendElement will construct a
> > path with a hard-coded '/' as separator. Of course on windows this will
> > give the wrong separator.
>
> [...]
> The path stuff is widely used throughout the libraries (for GWEN_DB,
> GWEN_XML, GWEN_DIRECTORY).
Ok. This particular function GWEN_Path_Convert, though, seems to be used only
in aqbanking's aqhbci.
> We could also accept '\' as path separator (hmm, don't we do that
> already?).
This particular separator mixup that I've reported could (IMHO) be fixed by
the attached patch (the macro GWEN_DIR_SEPARATOR as a character was
introduced by me in gwenhywfarapi.h a few revisions ago). Does that seem ok
to you?
As you've already said in the other thread, the path separator doesn't seem
too much of an issue anyway. On the other hand, the actual error in aqhbci
(in that yet other thread) with the extra escaping of "C:\" is indeed a
problem - can you respond to my proposal there, or should I already suggest a
path? Thanks for that.
Christian
Index: src/parser/path.c
===================================================================
--- src/parser/path.c (Revision 1166)
+++ src/parser/path.c (Arbeitskopie)
@@ -382,7 +382,7 @@
GWEN_Buffer_AppendString(ebuf, entry);
if (!(flags & GWEN_PATH_FLAGS_LAST) ||
!(flags & GWEN_PATH_FLAGS_VARIABLE))
- GWEN_Buffer_AppendByte(ebuf, '/');
+ GWEN_Buffer_AppendByte(ebuf, GWEN_DIR_SEPARATOR);
GWEN_Buffer_AllocRoom(ebuf, 1);
GWEN_Buffer_GetPosPointer(ebuf)[0]=0;
return data;
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Aqbanking-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/aqbanking-devel
