Hi, On Sunday 18 February 2007 20:31, Christian Stimming wrote: > Am Sonntag, 18. Februar 2007 14:24 schrieb Martin Preuss: [...] > > Hmm, we always use "/" for paths (e.g. for GWEN_DB paths), I don't think > > we should change that... > > > > Since the path stuff is used widely we shouldn't introduce these changes > > there. > > This particular function GWEN_Path_Convert and GWEN_Path_Append in *all* of > gwenhywfar and aqbanking and libchipcard is *only* used in aqhbci's > msglayer/hbci.c. Other functions of GWEN_Path might be used a lot more, but > they would not be affected by this change in GWEN_Path_Append. Am I wrong > here? If not, I suggest we should change the hard-coded path separator in > this particular function GWEN_Path_Append. All the rest of GWEN_Path is not > affected. [...]
Still, the path stuff is generic class, even though this particular function is only used by AqHBCI right now we shouldn't change the behaviour since the result would be unexpected (and wasn't intended). [...] > First of all I think the erroneous escaping happens in > AH_HBCI_SaveSettings, when called from AH_HBCI_SaveMessage, where the full > "path" is run through GWEN_Path_Convert at > aqhbci/plugin/msglayer/hbci.c:874. As a solution, I think this can be > solved by testing for path[1]==':' and if so, exclude the first two letters > from escaping. Suggested patch is attached. Does that sound good to you? [...] I think we could do it more easily: At that particular line we could just remove the escaping, it isn't necessary at that point. I don't even know why I put it there in the first place... Regards Martin -- "Things are only impossible until they're not" AqBanking - http://www.aqbanking.de/ LibChipcard - http://www.libchipcard.de/ ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Aqbanking-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/aqbanking-devel
