Hey Arjan!
On Sun, 23 Oct 2005 15:31:50 +0200, Arjan Timmerman wrote:
> hi all,
>
> I spend the last day hacking on gnome-system-tools. the progress is
> in unstable.
> at this time the time-admin,services-admin,boot-admin, users-admin
> are working and supported.
>
> known issues:
>
> - not every service will show up, this is caused due to our own
> naming schemes of daemons. if you find one please add a bug report
> or email me.
>
> Please test it, and tell me your troubles with it.
I was looking at your patch, and was wondering what the purpose of
these assignments are:
RC_INET_CONF => "/etc/rc.d/rc.conf",
RC_INET => "/etc/rc.d/rc.conf",
RC_LOCAL => "/etc/rc.d/rc.local",
Doesn't those files live in /etc on Arch? Anyway, I was just wondering
(as it seems to work) :-)
When you parse the rc.conf, you do it by matching the DAEMONS line,
but FAEMONS, TAEMONS, #AEMONS etc. are matched as well because \D means
any non-digit char. I'm sure you meant to match on /\s*DAEMONS/
Another small point of failure is that sh (and hence rc.conf) allows
line-breaking.
Perhaps it's worth to consider replacing
if(!$active)
{
$line =~ s/$script //;
}
with
$line =~ s/$script\s*// if !$active;
for both better readability and to match 0 or more whitespaces
instead of just a single space.
It's nice to finally see gnome-system-tools on Arch! As you know (if
you've checked your archlinux.org mailbox in the past week) I'd like to
help out with GNOME. Throw me a message if there's anything I can do for
this particular task. (I'm thinking @daemons, and if g-s-t allows us
to, maybe even start-up ordering and backgrounding options) :-)
Great work!
--
.-. Mark Rosenstand (-.)
oo| cc )
/`'\ (+45) 255 31337 3-n-(
(\_;/) [EMAIL PROTECTED] _(|/`->
_______________________________________________
arch mailing list
[email protected]
http://www.archlinux.org/mailman/listinfo/arch
