Hi James, I'm looking at the PR now, and while I can't speak to the code changes, it looks like the commits you authored are not properly linked to your GitHub account (otherwise your avatar icon would be used). This is presumably what is also causing the error message about the CLA.
I've had this happen when the local installation of git does not have the proper credentials, specifically e-mail. One way to fix this is `git config --global --edit` and then enter your full name and e-mail address that is linked to your GH account (you don't actually enter your github username there, it's the e-mail that's important). After you've set the credentials, the easiest approach may simply be to do the whole process over: 1. make a new branch from master in your local clone 2. recreate the commits and the messages 3. push that branch to your GH fork At that point you can look it over to make sure that the commits do properly have your avatar/account linked to them. Then you can create a new PR in the main Arches repo and close this existing one. Feel free to e-mail me directly if you have trouble with any of that. Adam On Tue, Mar 16, 2021 at 2:13 PM James Kemper <[email protected]> wrote: > Hello, > > I'm now working with Markus on our Arches implementation and have been > looking into this issue. > > From some research: > In the arches source code it calls `astimezone()` on the datetime objects. > But, as seen here in a python bug post > <https://bugs.python.org/issue36759>, there is a bug with that function *when > run on a Windows machine*. This is why the imports are failing for us as > we are using an Windows environment and I'm assuming the other tests have > succeeded because they running Arches on a Linux machine. > > I have also made a PR in the Arches Github project with a suggested > temporary change to handle this issue: > https://github.com/archesproject/arches/pull/7204 > > On Thursday, January 28, 2021 at 1:46:44 PM UTC-7, Markus S. wrote: >> >> Thanks Alexei! It must be something specific to my files or my system >> setups And yes, I can create dates older then 1970 via the UI. It's just >> the import where those don't get accepted. >> >> Galen, I believe Arches will generate it's own UUID if we pass as >> ResourceID values that are not valid UUIDs. The non-valid UUID will be >> stored as Legacy ID. The nice thing is that if I do another import and the >> new CSV import file also uses the Legacy ID in the ResourceID column, the >> imported (appended) data fill find its way to the correct record. So, in >> the CSV files I don't necessarily have to worry about the UUIDs. That is my >> experience so far. >> >> I will continue digging into my date issue. >> >> >> >> On Thursday, January 21, 2021 at 11:06:09 PM UTC-8 Alexei Peters wrote: >> >>> Hi Markus, >>> I just created a small graph based on your example. I allowed for >>> multiple values for the Evaluation Card. >>> With that setup, I was able to import a csv file structured exactly like >>> the one you specify above without any issue. >>> >>> Have you tried creating a date older than 1970 via the UI? If so did >>> that work? >>> If you can do that, maybe you should try exporting your data to see if >>> the format of the csv is the same as what you're trying to import. >>> >>> FYI I didn't need to specify resource ids as UUIDs for the import to >>> work. >>> Cheers, >>> Alexei >>> >>> Director of Web Development - Farallon Geographics, Inc. - 971.227.3173 >>> >>> >>> On Tue, Dec 15, 2020 at 3:35 PM Markus S. <[email protected]> wrote: >>> >>>> Hi, >>>> >>>> I ran into a bit of a curious issue while importing dates from a CSV >>>> file to a date field or fields in Arches v5.1. >>>> >>>> The CSV file looks roughly like this: >>>> >>>> *ResourceID,Period of Significance From Date,Period of Significance To >>>> Date* >>>> 3215,1985-01-01,1986-01-01 >>>> 3215,1964-01-01,1965-01-01 >>>> >>>> For any date before 1970-01-01, Arches import function (append to an >>>> existing record) produces Error #22: "invalid argument or is not a >>>> prefLabel in the given collection". Since it's a date import, not a >>>> concept, we can interpret this as "invalid argument". From the above >>>> sample, only the first row would get imported because the dates included >>>> are later than 1970-01-01 (which is the Unix epoch date, weirdly). >>>> >>>> In the Cards, the Minimum Date has been left empty. I also tried a >>>> minimum date a few hundred years back - did not make a difference. >>>> >>>> In the Resource Model, the branch is a simple one. Something like this: >>>> >>>> - DEMO model (E18) >>>> - Evaluation (E13) (semantic) >>>> - Period of Significance (E52) (semantic) >>>> - *Period of Significance From Date (E49) (date ISO-8601)* >>>> - *Period of Significance To Date (E49) (date ISO-8601)* >>>> >>>> >>>> Any advice? >>>> >>>> -- >>>> -- To post, send email to [email protected]. To unsubscribe, >>>> send email to [email protected]. For more information, >>>> visit https://groups.google.com/d/forum/archesproject?hl=en >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "Arches Project" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/archesproject/3336c6e1-e9ad-4e86-8861-97a16c26d6cbn%40googlegroups.com >>>> <https://groups.google.com/d/msgid/archesproject/3336c6e1-e9ad-4e86-8861-97a16c26d6cbn%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > -- To post, send email to [email protected]. To unsubscribe, > send email to [email protected]. For more > information, visit https://groups.google.com/d/forum/archesproject?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Arches Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/archesproject/5169bdf7-c9f8-4ac6-b0df-64739e99d6f2o%40googlegroups.com > <https://groups.google.com/d/msgid/archesproject/5169bdf7-c9f8-4ac6-b0df-64739e99d6f2o%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- To post, send email to [email protected]. To unsubscribe, send email to [email protected]. For more information, visit https://groups.google.com/d/forum/archesproject?hl=en --- You received this message because you are subscribed to the Google Groups "Arches Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/archesproject/CAGYBTasgSgwoh-WSELiM5te%3DUos_J%3D9OaUczjMmHW%2B7VbC8c8A%40mail.gmail.com.
