Hi,

Please find the notes of the code review on ws-discovery support for
cxf-based services. The related code can be found at
https://github.com/wso2/carbon-commons/tree/master/components/ws-discovery/org.wso2.carbon.discovery.cxf


- Currently, the code uses the org.apache.cxf.CXFServlet servlet config to
determine the webapp type. Need more effective way to determine the webapp
type.
    - Include an entry in the application descriptor file to get the webapp
type. Application descriptor support is not implemented yet.

- Limitation on reading class annotation to get @WebService info. This is
needed to generate the portType and targetNamespace. The annotation library
we are using, scannotation, do not have support to read annotation
attributes.
    - See the possibility of re-using CXF annotation reader code.

- Use CXF service client instead of axis2 service client to send
WS-Discovery requests (hello/bye).

- Look at the default cxf ws-discovery implementation and try to
simplify/reduce the code.

Thanks,
KasunG
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Reply via email to