Hi Eranda, We already send the serviceName and the wsdlURL as part of the WS-Discovery requests. That was the main reason to write our own implementation since ws-discovery is nearly unusable without these details.
Does the DiscoveryProxy provide support to receive JAX-RS services information like wadlURL etc. as well? Thanks, KasunG On Fri, May 2, 2014 at 4:12 AM, Eranda Sooriyabandara <[email protected]>wrote: > Hi Kasun, > In services we use to send the service name and the WSDL URL related to > that service in the service header. This was done as an improvement, which > does not defined in the ws-discovery spec. Here you can use those > improvements to send the webapp name as well as WADL url if applicable > which will be used when discover webapps using G-Reg. > > thanks > Eranda > > > On Thu, May 1, 2014 at 5:17 PM, Kasun Gajasinghe <[email protected]> wrote: > >> Hi, >> >> Please find the notes of the code review on ws-discovery support for >> cxf-based services. The related code can be found at >> https://github.com/wso2/carbon-commons/tree/master/components/ws-discovery/org.wso2.carbon.discovery.cxf >> >> >> - Currently, the code uses the org.apache.cxf.CXFServlet servlet config >> to determine the webapp type. Need more effective way to determine the >> webapp type. >> - Include an entry in the application descriptor file to get the >> webapp type. Application descriptor support is not implemented yet. >> >> - Limitation on reading class annotation to get @WebService info. This is >> needed to generate the portType and targetNamespace. The annotation library >> we are using, scannotation, do not have support to read annotation >> attributes. >> - See the possibility of re-using CXF annotation reader code. >> >> - Use CXF service client instead of axis2 service client to send >> WS-Discovery requests (hello/bye). >> >> - Look at the default cxf ws-discovery implementation and try to >> simplify/reduce the code. >> >> Thanks, >> KasunG >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > > *Eranda Sooriyabandara*Senior Software Engineer; > Integration Technologies Team; > WSO2 Inc.; http://wso2.com > Lean . Enterprise . Middleware > > E-mail: eranda AT wso2.com > Mobile: +94 716 472 816 > Linked-In: http://www.linkedin.com/in/erandasooriyabandara > Blog: http://emsooriyabandara.blogspot.com/ > > > > > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
