Hi Runshira, The main requirement in this scenario is to support the advance search capabilities that is already available in the G-Reg (in admin console), Properties, tags, comments, associations are all part of the artifact. Therefore saying properties as an internal registry level detail is illogical IMO. A user might want to add an artifact together with a property (whichi he/she doesn't want to show up in the rxt level attribute, for various reasons), might want to search from that property. Further, I suppose ES still uses properties in artifacts to achieve things like grouping and there could be many more. Furth If you are considering the already available method which takes the Map<String, List<String>>, even for that for searching through the property, you would still need to pass the propertyName, rightOp, rightPropertyValue as keys and corresponding values country, eq and usa as values in the list. If you are o.k to use this method, then a method that takes a string as a query would not be required.
Shazni Nazeer Mob : +94 777737331 LinkedIn : http://lk.linkedin.com/in/shazninazeer Blog : http://shazninazeer.blogspot.com On Fri, May 22, 2015 at 7:09 PM, Ruchira Wageesha <[email protected]> wrote: > > > On Fri, May 22, 2015 at 5:29 PM, Manuranga Perera <[email protected]> wrote: > >> That convenient method is not that convenient. >> >> Why >> "propertyName=country&rightOp=eq&rightPropertyValue=usa" >> Instead >> "country=usa" >> ? >> > If this is regarding the API that we requested during the meeting, then I > doubt whether you really address what we requested. i.e. You wanted a way > to search through registry properties etc. and find the relevant assets > from the ES. > > But, you have mentioned above that, there is an API named > findGenericArtifacts, > which expects a filtering criteria map. So, we don't really expect an API > which accept a query string instead of the map, which would be an > unnecessary thing as you will have to parse the string back to a map > somewhere down the line. > > What we requested is to have a API which deals only with the fields that > you have in RXT specification. i.e. In an RXT, there is nothing called > properties, which are registry low level concepts. Hence, in the ES > perspective, what we really worry is all the attributes that we have in the > RXT(asset). > > Hence, if you expect ES to search not only through the RXT fields, but > also through the properties associated with the RXT(asset), then ES will > have to go down to registry lower level concepts like properties. So, our > request was to abstract out that from you Generic Artifacts APIs and > provide a convenience method. > > i.e. When "xxx" is passed into your API, you can internally go into > wherever you need to search and finally return Generic Artifact instances > as the result. I don't think it is a good idea to introduce registry > resource level properties etc. into ES as those aren't at RXT level. If you > really need to have properties, then why do we introduce lower level > properties instead of going with something like unbounded fields etc. which > is there in the RXT model itself. > > Simply in ES point of view, we deal only with RXTs(assets) and its > attributes. Whenever you need to go down, either you will have to abstract > our from Generic Artifact APIs. Else, ES will be moving back to all the > stuff that we have in GReg admin console. > > /Ruchira > >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > > *Ruchira Wageesha**Technical Lead* > *WSO2 Inc. - lean . enterprise . middleware | wso2.com <http://wso2.com>* > > *email: [email protected] <[email protected]>, blog: > ruchirawageesha.blogspot.com <http://ruchirawageesha.blogspot.com>, > mobile: +94 77 5493444 <%2B94%2077%205493444>* > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > >
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
