Hi Susinda / Imesh, If positioning information is not stored with the diagram, does it auto adjust size and positioning of elements based on the length of text provided as lifeline labels and text on lines connecting lifelines? Further, are we allowing users to change the order of lifelines?
I think, although we might not need for sequence diagrams, in general it may be better to store positioning information with diagrams as auto layouting can be a complex problem. In addition, users may feel lack of control over the diagram, if they cannot position elements. For example, BPMN stores positioning information for each task and sequence in a separate xml section, which is referred by the corresponding logical construct when drawing the diagram in a canvas. Regards, Chathura On Tue, Aug 30, 2016 at 4:24 PM, Susinda Perera <[email protected]> wrote: > Hi Imesh > > +1 for all other suggestions and comments > Multiple groups added only to demonstrate the tool-palette features, not > needed for this editor but may be useful for datamapper editor. > We need to finalize the icons for the various tools/actions - Hope ESb > team can give some input > We will have UX review fix the other UI issues, +1 for go with a theme > approach (like dark/white) > I'll do the code refactoring for the name changes and positioning issues. > > Thanks > Susinda > > > On Tue, Aug 30, 2016 at 3:35 PM, Imesh Gunaratne <[email protected]> wrote: > >> Great work Susinda! Few comments below: >> >> - I think initially we may not need multiple groups inside the tool >> palette for sequence diagramming module. >> - Maybe we can directly use the exact tool palette elements we need; >> Lifecycles, Mediators, and Arrows. >> - The term Tool used at Tools.Models.Tool, might not suit well. Shall >> we call it an Element/Item (a tool palette element/item)? >> - The images used inside the tool palette may need to have >> transparent backgrounds. >> - Overall, we may also need to consider following: >> - As we do not store positioning data, we may need to do the >> positioning for the user. If so we may not need to provide user to >> change >> the positioning of elements as needed. >> - We might need to update the colours of the elements and the tool >> palette according to a colour scheme. >> >> Thanks >> >> >> On Tue, Aug 30, 2016 at 1:04 PM, Susinda Perera <[email protected]> wrote: >> >>> The same webpage can be seen at here[1] >>> [1] - https://wso2-incubator.github.io/js-tooling-framework/sequen >>> ce-editor/index.html >>> >>> Thanks >>> Susinda >>> >>> >>> On Tue, Aug 30, 2016 at 11:34 AM, Susinda Perera <[email protected]> >>> wrote: >>> >>>> Hi All >>>> >>>> I have started implementing $subject. Figure[1] below is the screenshot >>>> of the current implementation. >>>> The implementation pf Tool palette is devided to following models and >>>> views (considering extendability) and the js code[2] describes the >>>> connectivity of the modules. >>>> >>>> ToolPalette / ToolPaletteView >>>> --ToolGroupWraper / ToolGroupWraperView >>>> --ToolGroup / ToolgroupView >>>> --Tool / ToolView >>>> >>>> TODO >>>> - Implement the drag and drop support >>>> - Implement the collapse of tool palette >>>> - Externalize the templates for toolView, toolgroupWrapperView and >>>> toolPaletteView >>>> >>>> Please give your inputs >>>> >>>> >>>> >>>> [2] -js code >>>> //create tools >>>> var calcTool = new Tools.Models.Tool({ >>>> toolId: "tool1", >>>> toolImage:"images/icon1.png" >>>> }); >>>> >>>> var calcTool2 = new Tools.Models.Tool({ >>>> toolId: "tool2", >>>> toolImage:"images/icon1.png" >>>> }); >>>> >>>> //create tool group >>>> var group = new Tools.Models.ToolGroup(); >>>> group.add(calcTool); >>>> group.add(calcTool2); >>>> >>>> //create tool palette >>>> var toolPalette = new Tools.Models.ToolPalatte(); >>>> var toolGroupWrapper = new Tools.Models.ToolGroupWrapper({toolGroupName: >>>> "LifeLines", toolGroup:group}); >>>> toolPalette.add(toolGroupWrapper); >>>> >>>> //render the palate View >>>> var paletteView = new Tools.Views.ToolPalatteView({c >>>> ollection:toolPalatte}); >>>> paletteView.render(); >>>> >>>> [1] - screenshot >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> *Susinda Perera* >>>> Software Engineer >>>> B.Sc.(Eng), M.Sc(Computer Science), AMIE(SL) >>>> Mobile:(+94)716049075 >>>> Blog: susinda.blogspot.com >>>> WSO2 Inc. http://wso2.com/ >>>> Tel : 94 11 214 5345 Fax :94 11 2145300 >>>> >>>> >>> >>> >>> >>> -- >>> *Susinda Perera* >>> Software Engineer >>> B.Sc.(Eng), M.Sc(Computer Science), AMIE(SL) >>> Mobile:(+94)716049075 >>> Blog: susinda.blogspot.com >>> WSO2 Inc. http://wso2.com/ >>> Tel : 94 11 214 5345 Fax :94 11 2145300 >>> >>> >> >> >> -- >> *Imesh Gunaratne* >> Software Architect >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: https://medium.com/@imesh TW: @imesh >> lean. enterprise. middleware >> >> > > > -- > *Susinda Perera* > Software Engineer > B.Sc.(Eng), M.Sc(Computer Science), AMIE(SL) > Mobile:(+94)716049075 > Blog: susinda.blogspot.com > WSO2 Inc. http://wso2.com/ > Tel : 94 11 214 5345 Fax :94 11 2145300 > > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > >
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
