Hi Isura,
Thank you very much for your feedback.
I had gone through your comments and did the changes accordingly. Please
find the updated Swagger .yaml [1] attached below.
[1]
https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0
Thank You.
On Sat, Feb 10, 2018 at 1:19 AM, Isura Karunaratne <is...@wso2.com> wrote:
> Hi Chiran,
>
> Please find the inline comments.
>
> 1)
>
>
> POST/dialects/{id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/addClaimDialect>
> Add New Claim Dialect.
> The context for the posting a dialect should be like bellow.
>
>
> POST/dialects
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/addClaimDialect>
> Add New Claim Dialect.
> Also, the request body should contain, dialect URI (name) with the
> external claims array.
>
>
> 2)
>
>
>
> DELETE/dialect/{id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeClaimDialect>
> Delete Claim Dialect
> Delete claim dialect should be like bellow
>
> DELETE/dialects/{id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeClaimDialect>
> Delete Claim Dialect
>
>
> 3)
>
>
> GET/dialect
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/getClaimDialects>
> Get Available Claim Dialects
>
> Get Available Claim Dialects should be as follows.
>
>
> GET/dialects
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/getClaimDialects>
> Get Available Claim Dialects
>
>
> 4)
>
>
> PUT/dialect
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/renameClaimDialect>
> Update existing claim dialect.
>
> Update existing claim dialect should be as follows,
>
> PUT/dialects/{id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/renameClaimDialect>
> Update existing claim dialect.
>
>
>
> 5)
>
>
> PUT/dialects/{id}/claims
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateExternalClaim>
> update an external claim.
> DELETE/dialects/{id}/claims
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeExternalClaim>
> Delete external Claim
>
> Update and delete External claims should be as follows
>
>
> PUT/dialects/{dialect-id}/claims/{claim-id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateExternalClaim>
> update an external claim.
> DELETE/dialects/{dialect-id}/claims/{claim-id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeExternalClaim>
> Delete external Claim
>
>
>
>
>
>
>
> PUT/attributes
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateLocalClaim>
> Update a Local Claim.
>
> Update a Local Claim should be as follows
>
>
> PUT/attributes/{local-claim-id}
> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateLocalClaim>
> Update a Local Claim.
>
>
> Thanks
> Isura.
>
>
>
> On Fri, Feb 9, 2018 at 5:30 PM, Chiran Wijesekara <chir...@wso2.com>
> wrote:
>
>> Hi all,
>>
>> Please find the attached the link[1] to the swagger file of the REST API
>> design.
>> Would be glad to have your thoughts and feedback.
>>
>> [1] https://app.swaggerhub.com/apis/chirankavinda123/claim_manag
>> ement_service_endpoint/1.0.0
>> Thanks.
>>
>>
>> On Thu, Feb 8, 2018 at 10:37 AM, Chiran Wijesekara <chir...@wso2.com>
>> wrote:
>>
>>> Hi all,
>>>
>>> we have decided to create a REST endpoint for the purpose of claim
>>> management of WSO2 Identity Server future versions. Currently,
>>> ClaimMetaDataManagement Service is exposed as a SOAP endpoint as per the
>>> documentation provided under [1].
>>>
>>> As the first step toward the above effort, the prospective REST API will
>>> be designed with the help of Swagger. Further, this step has already been
>>> started and the thread will be updated with latest details.
>>>
>>> [1] https://docs.wso2.com/display/IS540/Managing+Claims+with+APIs
>>>
>>> Thank You.
>>> --
>>> *Chiran Wijesekara*
>>>
>>>
>>> *Software Engineering Intern | WSO2*Email: chir...@wso2.com
>>> Mobile: +94712990173web: www.wso2.com
>>>
>>> [image: https://wso2.com/signature] <https://wso2.com/signature>
>>>
>>
>>
>>
>> --
>> *Chiran Wijesekara*
>>
>>
>> *Software Engineering Intern | WSO2*Email: chir...@wso2.com
>> Mobile: +94712990173web: www.wso2.com
>>
>> [image: https://wso2.com/signature] <https://wso2.com/signature>
>>
>
>
>
> --
>
> *Isura Dilhara Karunaratne*
> Associate Technical Lead | WSO2
> Email: is...@wso2.com
> Mob : +94 772 254 810 <+94%2077%20225%204810>
> Blog : http://isurad.blogspot.com/
>
>
>
>
--
*Chiran Wijesekara*
*Software Engineering Intern | WSO2*Email: chir...@wso2.com
Mobile: +94712990173web: www.wso2.com
[image: https://wso2.com/signature] <https://wso2.com/signature>
_______________________________________________
Architecture mailing list
Architecture@wso2.org
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
