Hi all, After the review of *Swagger* *Design* of Claim Management Endpoint of WSO2 Identity Server, the source code for DTOs, Factories, and Service classes were generated using [1] as an *MSFJ service*.Then the MSF4J service was modified as an *OSGi service.* Then the msf4j-tomcat bridging component found under [2] was utilized to achieve the bridging mechanism between tomcat and netty. Currently, there is a considerable limitation with regard to this pattern which emerges in sample scenarios as follows. Suppose we need to access the TenantDomainin our MSF4J REST API. This cannot be achieved with the current implementation since the usual way of getting TenantDomain is via the ThreadLocalCarbonContext (*SYNC*) and the bridging mechanism is achieved in an asynchronous way. Hope this will be attended in future.
MSF4J Tomcat Bridge: https://github.com/ruwanta/msf4j-tomcat-bridge MS4J REST endpoint : https://github.com/chirankavinda123/claim-mgt- msf4j-endpoint Thank You. On Tue, Feb 13, 2018 at 3:24 PM, Chiran Wijesekara <[email protected]> wrote: > Hi Sanjeewa, > I will updated the relevant places accordingly. Thanks for pointing out. > Thank You. > > On Tue, Feb 13, 2018 at 12:58 PM, Sanjeewa Malalgoda <[email protected]> > wrote: > >> In that case please consider http status code 207[1] as simple resource >> update actually handle multiple resource updates (which usually refer as >> multi state update) >> >> [1]https://httpstatuses.com/207 >> >> Thanks, >> sanjeewa. >> >> On Tue, Feb 13, 2018 at 12:00 PM, Chiran Wijesekara <[email protected]> >> wrote: >> >>> Hi Sanjeewa, >>> >>> Local claims are termed as attributes. That is *Attributes = Local >>> claim Dialect* and further, the term attributes were used to lessen the >>> confusion between those two. >>> Thus, the dialect refers to the custom claim dialects other the Local >>> Claim Dialect.When adding a dialect, providing claims is optional. >>> And dialect contains external claims and just a mapping to local claims( >>> *under >>> Attributes*). >>> Hence, the claims that are supported by Identity Server is termed as >>> attributes. Dialects(winch are custom definitions) contain external claims >>> and mappings to ones under Attributes. >>> >>> Thanks. >>> >>> On Tue, Feb 13, 2018 at 11:50 AM, Chiran Wijesekara <[email protected]> >>> wrote: >>> >>>> Hi Prasanna, >>>> Appreciate your suggestion. However, It was done in such a way with the >>>> RESTful design guidelines and usability in mind. >>>> Thanks >>>> >>>> On Tue, Feb 13, 2018 at 11:28 AM, Sanjeewa Malalgoda <[email protected] >>>> > wrote: >>>> >>>>> It looks like claims are attributes of dialect. In that case when user >>>>> create/update dialect he should be able to create it with all claims he >>>>> need. >>>>> I hope that claims go to externalClaims tag in json. Can you explain >>>>> how it works? Is user allowed to create dialect with all claims at once? >>>>> If >>>>> few claims added updated while rest failed how we should handle it. >>>>> >>>>> Thanks, >>>>> sanjeewa. >>>>> >>>>> >>>>> On Tue, Feb 13, 2018 at 11:00 AM, Prasanna Dangalla <[email protected] >>>>> > wrote: >>>>> >>>>>> Hi Chiran, >>>>>> >>>>>> To mitigate the inconsistencies between SOAP end REST APIs >>>>>> parameters, is there a possibility to use same parameter names in SOAP >>>>>> and >>>>>> REST API's?. As an example in 'DeleteLocalClaim' in SOAP claim ID is >>>>>> 'claimDialectURI' and in the given REST API solution its 'local-claim-id >>>>>> '. >>>>>> >>>>>> Thanks >>>>>> >>>>>> *Prasanna Dangalla* >>>>>> Senior Software Engineer, WSO2, Inc.; http://wso2.com/ >>>>>> lean.enterprise.middleware >>>>>> >>>>>> >>>>>> *cell: +94 718 11 27 51* >>>>>> *twitter: @prasa77* >>>>>> >>>>>> On Mon, Feb 12, 2018 at 9:14 AM, Chiran Wijesekara <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Dakshika, >>>>>>> >>>>>>> Claim management via a REST API is not supported yet. Currently, it >>>>>>> is supported with SOAP. >>>>>>> Thank you for pointing out 409 and updated the .yml at appropriate >>>>>>> places. >>>>>>> >>>>>>> Thank You. >>>>>>> >>>>>>> On Mon, Feb 12, 2018 at 8:49 AM, Dakshika Jayathilaka < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Chiran, >>>>>>>> >>>>>>>> Aren't we support for adding local claim via REST API? >>>>>>>> Also, don't we need to add "409 conflicts" for the scenarios that >>>>>>>> resource already exists? >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> *Dakshika Jayathilaka* >>>>>>>> PMC Member & Committer of Apache Stratos >>>>>>>> Associate Technical Lead >>>>>>>> WSO2, Inc. >>>>>>>> lean.enterprise.middleware >>>>>>>> 0771100911 <077%20110%200911> >>>>>>>> >>>>>>>> On Sat, Feb 10, 2018 at 9:34 AM, Chiran Wijesekara < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Isura, >>>>>>>>> >>>>>>>>> Thank you very much for your feedback. >>>>>>>>> I had gone through your comments and did the changes accordingly. >>>>>>>>> Please find the updated Swagger .yaml [1] attached below. >>>>>>>>> [1] https://app.swaggerhub.com/apis/chirankavinda123/claim_manag >>>>>>>>> ement_service_endpoint/1.0.0 >>>>>>>>> >>>>>>>>> Thank You. >>>>>>>>> >>>>>>>>> On Sat, Feb 10, 2018 at 1:19 AM, Isura Karunaratne <[email protected] >>>>>>>>> > wrote: >>>>>>>>> >>>>>>>>>> Hi Chiran, >>>>>>>>>> >>>>>>>>>> Please find the inline comments. >>>>>>>>>> >>>>>>>>>> 1) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> POST/dialects/{id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/addClaimDialect> >>>>>>>>>> Add New Claim Dialect. >>>>>>>>>> The context for the posting a dialect should be like bellow. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> POST/dialects >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/addClaimDialect> >>>>>>>>>> Add New Claim Dialect. >>>>>>>>>> Also, the request body should contain, dialect URI (name) with >>>>>>>>>> the external claims array. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> DELETE/dialect/{id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeClaimDialect> >>>>>>>>>> Delete Claim Dialect >>>>>>>>>> Delete claim dialect should be like bellow >>>>>>>>>> >>>>>>>>>> DELETE/dialects/{id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeClaimDialect> >>>>>>>>>> Delete Claim Dialect >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 3) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> GET/dialect >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/getClaimDialects> >>>>>>>>>> Get Available Claim Dialects >>>>>>>>>> >>>>>>>>>> Get Available Claim Dialects should be as follows. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> GET/dialects >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/getClaimDialects> >>>>>>>>>> Get Available Claim Dialects >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 4) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> PUT/dialect >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/renameClaimDialect> >>>>>>>>>> Update existing claim dialect. >>>>>>>>>> >>>>>>>>>> Update existing claim dialect should be as follows, >>>>>>>>>> >>>>>>>>>> PUT/dialects/{id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/renameClaimDialect> >>>>>>>>>> Update existing claim dialect. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 5) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> PUT/dialects/{id}/claims >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateExternalClaim> >>>>>>>>>> update an external claim. >>>>>>>>>> DELETE/dialects/{id}/claims >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeExternalClaim> >>>>>>>>>> Delete external Claim >>>>>>>>>> >>>>>>>>>> Update and delete External claims should be as follows >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> PUT/dialects/{dialect-id}/claims/{claim-id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateExternalClaim> >>>>>>>>>> update an external claim. >>>>>>>>>> DELETE/dialects/{dialect-id}/claims/{claim-id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/removeExternalClaim> >>>>>>>>>> Delete external Claim >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> PUT/attributes >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateLocalClaim> >>>>>>>>>> Update a Local Claim. >>>>>>>>>> >>>>>>>>>> Update a Local Claim should be as follows >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> PUT/attributes/{local-claim-id} >>>>>>>>>> <https://app.swaggerhub.com/apis/chirankavinda123/claim_management_service_endpoint/1.0.0#/operations/default/updateLocalClaim> >>>>>>>>>> Update a Local Claim. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> Isura. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Feb 9, 2018 at 5:30 PM, Chiran Wijesekara < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi all, >>>>>>>>>>> >>>>>>>>>>> Please find the attached the link[1] to the swagger file of the >>>>>>>>>>> REST API design. >>>>>>>>>>> Would be glad to have your thoughts and feedback. >>>>>>>>>>> >>>>>>>>>>> [1] https://app.swaggerhub.com/apis/chirankavinda123/claim_manag >>>>>>>>>>> ement_service_endpoint/1.0.0 >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Thu, Feb 8, 2018 at 10:37 AM, Chiran Wijesekara < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi all, >>>>>>>>>>>> >>>>>>>>>>>> we have decided to create a REST endpoint for the purpose of >>>>>>>>>>>> claim management of WSO2 Identity Server future versions. >>>>>>>>>>>> Currently, >>>>>>>>>>>> ClaimMetaDataManagement Service is exposed as a SOAP endpoint as >>>>>>>>>>>> per the >>>>>>>>>>>> documentation provided under [1]. >>>>>>>>>>>> >>>>>>>>>>>> As the first step toward the above effort, the prospective REST >>>>>>>>>>>> API will be designed with the help of Swagger. Further, this step >>>>>>>>>>>> has >>>>>>>>>>>> already been started and the thread will be updated with latest >>>>>>>>>>>> details. >>>>>>>>>>>> >>>>>>>>>>>> [1] https://docs.wso2.com/display/ >>>>>>>>>>>> IS540/Managing+Claims+with+APIs >>>>>>>>>>>> >>>>>>>>>>>> Thank You. >>>>>>>>>>>> -- >>>>>>>>>>>> *Chiran Wijesekara* >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> *Software Engineering Intern | WSO2*Email: [email protected] >>>>>>>>>>>> Mobile: +94712990173web: www.wso2.com >>>>>>>>>>>> >>>>>>>>>>>> [image: https://wso2.com/signature] >>>>>>>>>>>> <https://wso2.com/signature> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Chiran Wijesekara* >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> *Software Engineering Intern | WSO2*Email: [email protected] >>>>>>>>>>> Mobile: +94712990173web: www.wso2.com >>>>>>>>>>> >>>>>>>>>>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> *Isura Dilhara Karunaratne* >>>>>>>>>> Associate Technical Lead | WSO2 >>>>>>>>>> Email: [email protected] >>>>>>>>>> Mob : +94 772 254 810 <+94%2077%20225%204810> >>>>>>>>>> Blog : http://isurad.blogspot.com/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Chiran Wijesekara* >>>>>>>>> >>>>>>>>> >>>>>>>>> *Software Engineering Intern | WSO2*Email: [email protected] >>>>>>>>> Mobile: +94712990173web: www.wso2.com >>>>>>>>> >>>>>>>>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Architecture mailing list >>>>>>>>> [email protected] >>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Chiran Wijesekara* >>>>>>> >>>>>>> >>>>>>> *Software Engineering Intern | WSO2*Email: [email protected] >>>>>>> Mobile: +94712990173web: www.wso2.com >>>>>>> >>>>>>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Architecture mailing list >>>>>>> [email protected] >>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>> >>>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Architecture mailing list >>>>>> [email protected] >>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *Sanjeewa Malalgoda* >>>>> WSO2 Inc. >>>>> Mobile : +94713068779 <+94%2071%20306%208779> >>>>> >>>>> <http://sanjeewamalalgoda.blogspot.com/>blog >>>>> :http://sanjeewamalalgoda.blogspot.com/ >>>>> <http://sanjeewamalalgoda.blogspot.com/> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> [email protected] >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Chiran Wijesekara* >>>> >>>> >>>> *Software Engineering Intern | WSO2*Email: [email protected] >>>> Mobile: +94712990173web: www.wso2.com >>>> >>>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>>> >>> >>> >>> >>> -- >>> *Chiran Wijesekara* >>> >>> >>> *Software Engineering Intern | WSO2*Email: [email protected] >>> Mobile: +94712990173web: www.wso2.com >>> >>> [image: https://wso2.com/signature] <https://wso2.com/signature> >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> >> *Sanjeewa Malalgoda* >> WSO2 Inc. >> Mobile : +94713068779 <+94%2071%20306%208779> >> >> <http://sanjeewamalalgoda.blogspot.com/>blog >> :http://sanjeewamalalgoda.blogspot.com/ >> <http://sanjeewamalalgoda.blogspot.com/> >> >> >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > *Chiran Wijesekara* > > > *Software Engineering Intern | WSO2*Email: [email protected] > Mobile: +94712990173web: www.wso2.com > > [image: https://wso2.com/signature] <https://wso2.com/signature> > -- *Chiran Wijesekara* *Software Engineering Intern | WSO2*Email: [email protected] Mobile: +94712990173web: www.wso2.com [image: https://wso2.com/signature] <https://wso2.com/signature>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
