On 6 Nov 06, at 5:57 AM 6 Nov 06, Brett Porter wrote:
I'm not convinced about this. This is basically ignoring checksums
in the source repository - shouldn't we be forcing them to correct
them? I'd like to do the same thing on sync.
It's logged and we can point people at the report to correct them.
Otherwise the whole conversion stops dead and not. I'll take not
stopping dead and providing a warning. What we should do with the
warning should be improved so that people who are syncing know what
to correct.
Jason.
- Brett
On 05/11/2006, at 1:43 PM, [EMAIL PROTECTED] wrote:
Author: jvanzyl
Date: Sat Nov 4 18:43:13 2006
New Revision: 471342
URL: http://svn.apache.org/viewvc?view=rev&rev=471342
Log:
MRM-219 Convert a POM even if the checksum for the POM is incorrect
Modified:
maven/archiva/trunk/archiva-converter/src/main/java/org/apache/
maven/archiva/converter/DefaultRepositoryConverter.java
Modified: maven/archiva/trunk/archiva-converter/src/main/java/org/
apache/maven/archiva/converter/DefaultRepositoryConverter.java
URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-
converter/src/main/java/org/apache/maven/archiva/converter/
DefaultRepositoryConverter.java?
view=diff&rev=471342&r1=471341&r2=471342
=====================================================================
=========
--- maven/archiva/trunk/archiva-converter/src/main/java/org/apache/
maven/archiva/converter/DefaultRepositoryConverter.java (original)
+++ maven/archiva/trunk/archiva-converter/src/main/java/org/apache/
maven/archiva/converter/DefaultRepositoryConverter.java Sat Nov 4
18:43:13 2006
@@ -273,6 +273,7 @@
String snapshotKey = null;
String versionKey = null;
String versionsKey = null;
+
if ( repositoryMetadata.storedInGroupDirectory() )
{
groupIdKey = "failure.incorrect.groupMetadata.groupId";
@@ -407,8 +408,10 @@
if ( testChecksums( artifact, file, reporter ) )
{
checksumsValid = true;
- contents = FileUtils.fileRead( file );
}
+
+ // Even if the checksums for the POM are invalid
we should still convert the POM
+ contents = FileUtils.fileRead( file );
}
catch ( IOException e )
{
