On 6 Nov 06, at 8:18 AM 6 Nov 06, Brett Porter wrote:
On 06/11/2006, at 12:49 PM, Jason van Zyl wrote:
On 6 Nov 06, at 5:57 AM 6 Nov 06, Brett Porter wrote:
I'm not convinced about this. This is basically ignoring
checksums in the source repository - shouldn't we be forcing them
to correct them? I'd like to do the same thing on sync.
It's logged and we can point people at the report to correct them.
Otherwise the whole conversion stops dead and not. I'll take not
stopping dead and providing a warning. What we should do with the
warning should be improved so that people who are syncing know
what to correct.
Yeah, stopping dead is bad - so does this report and not sync them,
or does it report and autocorrect them? I'm leaning towards the
first - report the problem, sync everything else, but skip the ones
with bad source checksums.
http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-converter/
src/main/java/org/apache/maven/archiva/converter/
DefaultRepositoryConverter.java?
diff_format=h&r1=471341&r2=471342&pathrev=471342
Right now, if the checksum is incorrect it warns but still converts
the POM. But I agree it should probably reject it and make the source
fix it. Auto-correcting stuff will become a maintenance problem for
us. If it doesn't cut muster then we should just throw it back where
it came from.
For now I just kept it from dying and convert anything we can get our
hands on.
Jason.
- Brett
