On 10 March 2010 16:25, Jarek Gawor <[email protected]> wrote: > Hi, > > I've been looking at the application code a little bit and have a few > observations/changes I would like to make: > > 1) Some files are named AriesApplication*.java and some are > Application*.java. To have consistent names I think we should rename > some of these AriesApplication*.java files to Application*.java (i.e. > drop the 'Aries' prefix) > > 2) The BundleInfoImpl.java class seems pretty generic so I would like > to move it to the "utils" bundle (and maybe rename it as > SimpleBundleInfo or something like that) > > 3) There is no way right now to save an application in "expanded form" > into a directory (i.e. not as a file) So I would like to either 1) > modify AriesApplicationImpl.store(File) to handle directories as well > as files or 2) add additional method to AriesApplication for storing > the application into a directory. > > 4) Seems like DeploymentMetadataFactory is missing a couple of methods > for creating DeploymentMetadata directly from an InputStream or > Manifest. I would like to add these. > > Any objections to these changes?
All sounds good to me. > > Thanks, > Jarek >
