On Wed, Mar 10, 2010 at 12:11 PM, Alasdair Nottingham <[email protected]> wrote: > On 10 March 2010 16:25, Jarek Gawor <[email protected]> wrote: >> Hi, >> >> I've been looking at the application code a little bit and have a few >> observations/changes I would like to make: >> >> 1) Some files are named AriesApplication*.java and some are >> Application*.java. To have consistent names I think we should rename >> some of these AriesApplication*.java files to Application*.java (i.e. >> drop the 'Aries' prefix) > > I think the inconsistency is bad, but I did think having Aries at the > front made sense, if we end up with an OSGi standard version of these > interfaces having the Aries at the front would mean you don't need to > fully qualify the class name if you ever need both, such as > implementing both.
Either way is fine with me as long as we are consistent. So prepending "Aries" to every Application*.java sounds good. >> >> 2) The BundleInfoImpl.java class seems pretty generic so I would like >> to move it to the "utils" bundle (and maybe rename it as >> SimpleBundleInfo or something like that) > > Which utils bundle are you thinking of? The application specific one > or the global one? application specific one. Jarek
