Hi, comments below. Thanks Lin
On Thu, Apr 1, 2010 at 2:39 PM, Guillaume Nodet <[email protected]> wrote: > Yeah, but that's really an implementation detail. Suffice to say that the > SubsystemAdmin will operate in the composite it is retrieved from and that > when a subsystem is created, a SubstemAdmin for this composite will be > made available. > The way we implement it is ... an implementation detail imho. > But yes, I'm thinking about registering a ServiceFactory as the > SubsystemAdmin > service so that we can retrieve the requesting bundle, hence it's > BundleContext > and/or the composite it lives in. Yep agreed that this is an implementation detail but it is important to understand it so that we know we can get hold of the request client's bundle context :) > Yeah, I'm still a bit worried to introduce the composite as I think in one > of the last EEG meetings, > the consensus was to hide composite rather than expose those. We'll see. To me, we've already exposed the constituent in the API. If we don't provide the getComposite() method, we could get hold of the composite via the right bundle context and the bundle id in the SubsystemAdmin. >> I have a question on install location/artifact of >> SubsystemAdmin.install(). Can I assume the install location would be >> a url location to the application that is in .eba format or exploded >> eba dir? >> > > I don't think passing an exploded url would work, because we need an input > stream > and you can't navigate through an exploded archive over http ... > Though it's not really hard to just create this stream on the fly. > If you look at felix fileinstall, it even provides a URL handler to do that. > So you could do: > admin.install("jardir:/aries/deploy/my.eba") I agree that dealing with archive would be more straightforward. I think equinox is doing similar thing by providing a file url handler to handle file installation. Does it make sense to clarify what should be supported via the javadoc or it is up to the implementation?
