On Sat, Apr 3, 2010 at 1:51 AM, Guillaume Nodet <[email protected]> wrote: > On Fri, Apr 2, 2010 at 23:03, Alasdair Nottingham <[email protected]> wrote: > >> So comments on the current SubsystemAdmin: >> >> 1. How about a getSubsystem(String symbolicName, Version version); >> > > That sounds much better than getScope() and getSubsystem(scope) imho.
I like it too :) >> 2. What is the scope of SubsystemAdmin? Is it framework, composite >> bundle, subsystem scoped? >> > > Imho, composite. However, the SubsystemAdmin if inherited from its parent > composite, it needs to be able to manage the composite it has been requested > from. I.e. if you retrieve the SubsystemAdmin using a given BundleContext, > the returned service will manage the composite from this BundleContext. Yep I was thinking it is the scope of the composite/subsystem. If we decided to let users to get hold of subsystem via symbolic name and version in subsystemAdmin, then we don't need to introduce the concept of scope. Thanks Lin
