Hi, With respect to commenting I'm planning on committing some updates which remove the comment service since we have no implementation. Maybe one day that will change, but until then I would like the code to be simpler.
Alasdair Alasdair Nottingham On 22 Sep 2010, at 10:00, Emily Jiang <[email protected]> wrote: > Hi Zoe, > > Personally, I would think it is good to use obr resolver in the blog itest > to exercise our provisioning. I am hoping when felix obr fixes the jira we > raised for the optional service provisioning. We can bring back the > optional comment service. At the moment, it does not make any difference > as it is optional and no comment service is provided. If the decision is > to switch to use no-op resolver, the following code need to be changed in > the blog itest for jdbc, jpa and quiesce java code: > > just replace: > mavenBundle("org.apache.aries.application", > "org.apache.aries.application.resolver.obr"), > with > mavenBundle("org.apache.aries.application", > "org.apache.aries.application.resolver.noop"), > > and then in the pom.xml of the blog itest > replace > <dependency> > <groupId>org.apache.aries.application</groupId> > <artifactId>org.apache.aries.application.resolver.obr</ > artifactId> > <scope>test</scope> > </dependency> > > with > > <dependency> > <groupId>org.apache.aries.application</groupId> > <artifactId>org.apache.aries.application.resolver.noop</ > artifactId> > <scope>test</scope> > </dependency> > > Regards > Emily > > > > From: zoe slattery <[email protected]> > To: [email protected] > Date: 22/09/2010 17:12 > Subject: Blog Sample > > > > I now have a working version of the blog sample. Yay! > > I have a question about one of the fixes though. In Joe's most recent > fix he fixed Java code in BloggingServiceImpl.java (which probably > needed fixing anyway). I think Joe was avoiding an NPE which was caused > by changes to changes to the blueprint configuration to comment out the > optional service. > ( > https://svn.apache.org/repos/asf/incubator/aries/trunk/samples/blog/blog-biz/src/main/resources/OSGI-INF/blueprint/blueprint.xml > ). > > With the recent changes to re-instate the no-op resolver, should I be > able to revert the changes to the blueprint as well? If I do, what else > will need fixing? Tests? > > Zoë > > > > > > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > >
