Now that I've "fixed" ARIES-425, the blog sample can be used complete with optional services and OBR. There is still a problem with the blog (and probably all our bundles) in that they contain spurious, non-standard, Import-Service and Export-Service headers for blueprint services. I've adjusted our code to tolerate the way they specify optionality, but I have no idea what else might go wrong with them.
We really need to find a way to turn them off. Regards, Tim ---------------------------------------- > To: [email protected] > Subject: Re: Blog Sample > From: [email protected] > Date: Wed, 22 Sep 2010 22:42:59 +0100 > >>>So, do you think the sample will all work if I just remove those > comments? I'm asking because I tried once and the tests failed. I'm not > sure if I failed to delete the comments properly and I'd rather know if > you expect it to work before I try again :-) > > EJ: It should work after you delete the commented code and comment > service. I can supply a patch tomorrow if needed. > > > > > On 22/09/2010 18:00, Emily Jiang wrote: >> Hi Zoe, >> >> Personally, I would think it is good to use obr resolver in the blog > itest >> to exercise our provisioning. I am hoping when felix obr fixes the jira > we >> raised for the optional service provisioning. We can bring back the >> optional comment service. At the moment, it does not make any difference >> as it is optional and no comment service is provided. > > >> If the decision is >> to switch to use no-op resolver, the following code need to be changed > in >> the blog itest for jdbc, jpa and quiesce java code: >> >> just replace: >> mavenBundle("org.apache.aries.application", >> "org.apache.aries.application.resolver.obr"), >> with >> mavenBundle("org.apache.aries.application", >> "org.apache.aries.application.resolver.noop"), >> >> and then in the pom.xml of the blog itest >> replace >> >> org.apache.aries.application >> org.apache.aries.application.resolver.obr>> artifactId> >> test >> >> >> with >> >> >> org.apache.aries.application >> org.apache.aries.application.resolver.noop>> artifactId> >> test >> >> >> Regards >> Emily >> >> >> >> From: zoe slattery >> To: [email protected] >> Date: 22/09/2010 17:12 >> Subject: Blog Sample >> >> >> >> I now have a working version of the blog sample. Yay! >> >> I have a question about one of the fixes though. In Joe's most recent >> fix he fixed Java code in BloggingServiceImpl.java (which probably >> needed fixing anyway). I think Joe was avoiding an NPE which was caused >> by changes to changes to the blueprint configuration to comment out the >> optional service. >> ( >> > https://svn.apache.org/repos/asf/incubator/aries/trunk/samples/blog/blog-biz/src/main/resources/OSGI-INF/blueprint/blueprint.xml > >> ). >> >> With the recent changes to re-instate the no-op resolver, should I be >> able to revert the changes to the blueprint as well? If I do, what else >> will need fixing? Tests? >> >> Zoë >> >> >> >> >> >> >> >> >> >> Unless stated otherwise above: >> IBM United Kingdom Limited - Registered in England and Wales with number >> 741598. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU >> >> >> >> >> >> > > > > > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > >
