Faré writes: > 1- While the trivial convenience function bundle-system was removed, > the underlying functionality still exists. The function was ill-named > legacy of dubious value. Do ABCL users actually use this function as > such?
bundle-system is a function with a good name, reflecting it's premise – it creates bundled system. I.e it's not less valid than require-system or anything else. > > 2- On the other hand, its removal is a bit brutal. It might have been > better to use the gradual removal strategy we were thinking of in > branch obsolete-function-warnings. Maybe there's a case for reversing > this removal before next release, and instead completing and merging > that branch and using it. I however do not volunteer for the job at > this point. This removal was my mistake, not a brutal "right thing to do". > > 3- I merged part of this pull request into 3.1.7.13. Please merge my merge request in full, unless you find a technical problems with it. > > —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org > What is mind? No matter! What is matter? Never mind! > — Bertrand Russell's Grand Mother, In Karl Popper, The Unended > Quest Regards, Daniel > > > On Sun, Sep 11, 2016 at 8:32 AM, Jean-Claude Beaudoin > <jean.claude.beaud...@gmail.com> wrote: >> >> >> On Sun, Sep 11, 2016 at 8:12 AM, Daniel Kochmański <dan...@turtleware.eu> >> wrote: >>> >>> Hey, >>> >>> now all MKCL tests pass as expected. I've also disabled load-bundle-op >>> as a default option (seems like a MKCL bug): >>> >>> https://gitlab.common-lisp.net/asdf/asdf/merge_requests/11 >> >> >> I'll have to look deeper into that load-bundle-op question... >> >>> >>> >>> The issue with the system modules is caused by a muss in the systems >>> definitions of MKCL. Namely asd files are bogus – for instance there is >>> (repeated) cmp.asd definition in contrib/ directory pointing and cmp.a >>> file, but the latter isn't present there. `locate-system' takes the >>> cmp.asd from the contrib/ directory and can't inject proper module. I've >>> disabled for mkcl find-system check, but mkcl will fail, if any asd >>> system has "cmp" in `:depends-on' (and this is not a regression, it was >>> like this before and is a problem with mkcl asd files). >>> >> >> Yep, that's a bug. I had not noticed that bogus cmp.asd before now, that's >> bad. >> >>> >>> Long story short – everything is as fine as was before this "wave of >>> change". >>> >> >> Thanks, I'll give the test suite one more spin as soon as I get an >> opportunity, >> just to confirm. >> >> -- Daniel Kochmański ;; aka jackdaniel | Poznań, Poland TurtleWare - Daniel Kochmański | www.turtleware.eu "Be the change that you wish to see in the world." - Mahatma Gandhi