Andy, I still investigating the issue, I'm not sure that it actually concerns AspectJ and not Spring. When I have switched from Spring's TomcatInstrumentableClassLoader defined in application context to javaagent, problem has gone and everything worked as expected. Looks like it limitation of TomcatInstrumentableClassLoader, when I commented out spring context initialization in web.xml and leaved only single test servlet I wanted to weave I could not get it weaved with custom classloader defined in application context.xml.default. But I can weave it if I define aspectj weaver as javaagent. Peter
On Thu, Jun 24, 2010 at 10:10 PM, Andy Clement <[email protected]>wrote: > As you haven't raised it, I raised > https://bugs.eclipse.org/bugs/show_bug.cgi?id=317874 to discuss your > first problem. If we can come up with a nice test scenario that shows > the situation clearly, we can think about possible > improvements/solutions. > > Andy > > On 23 June 2010 12:34, Andy Clement <[email protected]> wrote: > > Hi Peter, > > > > On problem (2), please see > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=317743 . I've attached a > > patch with instructions on how to apply it to aspectjweaver 1.6.9. It > > is a pair of problems causing you a big headache (both bugs). The use > > of annotation style rather than code style aspects makes the problem > > far worse. The patch should address it - can you try it and let me > > know? (append a comment on the bug report) > > > > cheers, > > Andy > > > > On 23 June 2010 11:45, Andy Clement <[email protected]> wrote: > >> Hi Peter, > >> > >> If you can come up with a simple failing scenario, that would be > >> awesome! If we are quick enough, there may be room to resolve this > >> for 1.6.9. > >> > >> cheers, > >> Andy > >> > >> On 23 June 2010 10:59, Peter Melnikov <[email protected]> wrote: > >>> Hello > >>> Andy, > >>> I have forgotten to say I use 1.6.8 version > >>>> > >>>> On your aop.xml file, I hope you are including the aspect with your > >>>> > >>>> include within clause. I can't tell as you didn't say which package > >>>> > >>>> it was in. You may have issues if your aspect is not in the > >>>> > >>>> net.mansion package hierarchy. > >>> > >>> > >>> Yes you are right it is in net.mansion.logging package that is included > in > >>> aop.xml. The aspect class is deployed under WEB-INF/lib as a jar file. > >>>> > >>>> On problem (2) I vaguely recall a bugzilla related to that, but can't > >>>> > >>>> find it in a quick search. You should open a separate one for that > >>>> > >>>> issue. > >>> > >>> I did a look and found a message that describes the same problem: > >>> http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg10323.html > >>> I will think how to come up with reproduceable test cases for both > issues. > >>> regards, > >>> Peter > >>> > >>> _______________________________________________ > >>> aspectj-users mailing list > >>> [email protected] > >>> https://dev.eclipse.org/mailman/listinfo/aspectj-users > >>> > >>> > >> > > > _______________________________________________ > aspectj-users mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/aspectj-users >
_______________________________________________ aspectj-users mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/aspectj-users
