Re: [aspell-devel] MSYS patch

[Kevin Tew]

Gary Setter wrote:
--- aspell-orig/common/config.cpp    Mon Dec 27 20:42:23 2004
+++ aspell-new/common/config.cpp    Fri Feb  4 11:15:32 2005
@@ -9,12 +9,12 @@
#include <string.h>
#include <stdlib.h>
#include <assert.h>
+#include "settings.h"
#ifdef WIN32PORT
#include <windows.h>// GetModuleFilename
#include <shlobj.h> // SHGetSpecialFolderLocation
extern void * get_module_handle();
#endif
-#include "settings.h"
#include "dirs.h"
#ifdef USE_LOCALE
@@ -618,7 +618,7 @@
      else if (strcmp(i, "prefix") == 0) {
        char * buff = new char [MAX_PATH];
-        HMODULE hand = reinterpret_cast<HMODULE>
   

(get_module_handle());
 

+        HMODULE hand = GetModuleHandle("libaspell.dll");
        if (GetModuleFileName(hand, buff, MAX_PATH)) {
          //convert all \ chars to /
          for (char *ptr = buff; *ptr; ++ptr)
diff -ur aspell-orig/common/lock.hpp aspell-new/common/lock.hpp
--- aspell-orig/common/lock.hpp    Thu Sep 23 07:25:24 2004
+++ aspell-new/common/lock.hpp    Fri Feb  4 11:42:57 2005
@@ -18,6 +18,9 @@
#include "settings.h"
#ifdef USE_POSIX_MUTEX
+#ifdef WIN32PORT
+#  include "minwin.h"
+#endif
#  include <pthread.h>
#endif
   

Hi Kevin,
Whould you consider saving the the handle of the aspell lib at
the time you do your LoadLibrary and define get_module_handle()
to return that handle?
 

Sorry don't follow the LoadLibrary logic ? What LoadLibrary call are you 
talking about?
I'm using the libaspell.dll libarary and just dynamically linking 
against it.

What types of things are you exporting from your version of the
dll? The 0.5 version exported a lot of class methods and whole
classes. I thought the project was moving in the direction of a c
only interface. Are we there yet?
Best regards,
Gary
 

I'm using auto-import functionallity that basically exports everything.
once aspell.exe only uses the c interface we can look at this again.
Kevin Tew
_______________________________________________
Aspell-devel mailing list
Aspell-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/aspell-devel