I didn't think you caused it. I suppose I should go ahead and apply your changes.
I've had a _heck_ of a time freeing all the glib mainloop structures and having it work on all versions of glib. I don't know what I did to cause this to start failing. Sigh... I finally gave up and filed a bug with the glib people saying it is insufficiently documented and they need to fix that, and write tests, and then make their code pass the tests... https://bugzilla.gnome.org/show_bug.cgi?id=696201 I perfectly agree with small steps. I will try and commit your changes today. On 03/20/2013 08:02 AM, Roger wrote: > Hi Alan, > > The patch only touched 3 CMakeLists.txt files. I have not worried > about install yet. We are a long ways > from needing a windows install. I hope to have had no effect on the > linux cmake and certainly not on > linux execution. > > When I get a clean compile from I will send you those changes. > > Then we can try to get it to do something useful (more changes). > > I think it is better to get there in small steps. > > Generalizing cmake rules will be part of the process. > > Roger > > On 03/19/2013 08:49 PM, Alan Robertson wrote: >> I understand most of this, and I'll take this patch as-is... >> >> There are a couple of things... >> >> You still need make install to work on Windows. >> >> In general, it's better to change some defines and have the rules be >> the same than to have different rules. That makes maintaining things >> harder. >> >> Thanks for the patch! >> > -- Alan Robertson <[email protected]> - @OSSAlanR "Openness is the foundation and preservative of friendship... Let me claim from you at all times your undisguised opinions." - William Wilberforce
_______________________________________________ Assimilation mailing list - Discovery-Driven Monitoring [email protected] http://lists.community.tummy.com/cgi-bin/mailman/listinfo/assimilation http://assimmon.org/
