Thomas,

My Version: 2.1.2(11356)

Note that I downloaded 2.1.2(12042) and checked the code. For purposes 
of this issue, they have essentially the same logic flow in the target 
code area.

Note that when set to block, DoBlackRe is supposed to be No Optout.

For sometime, I have wondered why certain email messages were not 
blocked. I finally confirmed my suspicion.

The issue is code flow. In sub getbody(), the flow is:

Red check
Whitelisted check
CheckAttachments
BombOK
ScriptOK
BombBlackOK

The issue is that the BombOK check can score the message as spam, but 
not block. So, apparently, the BombBlackOK is not executed. I am of the 
opinion that at minimum, the code flow should be:

Red check
Whitelisted check
CheckAttachments
BombBlackOK
BombOK
ScriptOK

But, because there is no optout, it probably should be:

BombBlackOK
Red check
Whitelisted check
CheckAttachments
BombOK
ScriptOK

I did not chase down what the flag does, but it also looks like 
BombBlackOK sets a flag for SpamLover:

my $slok=$this->{allLoveBoSpam}==1;

Becuase that is the same flag as in BombOK, I am guessing that should 
not happen.

I am happy to make those changes and test here, but wanted to get your 
opinion first.

-- 
Michael Thomas
Mathbox
978-687-3300
Toll Free: 1-877-MATHBOX (1-877-628-4269)


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test

Reply via email to