>I am happy to make those changes and test here, but wanted to get your
>opinion first.
IMHO this code part has no issue.
>The issue is that the BombOK check can score the message as spam, but
not block. So, apparently, the BombBlackOK is not executed.
This is not true.
BombBlackOK and BombOK have nothing to do with each other. They are using
sepatate setting and code.
>I did not chase down what the flag does, but it also looks like
>BombBlackOK sets a flag for SpamLover:
>my $slok=$this->{allLoveBoSpam}==1;
The flag is checked not set! Both bomb features checks this flag.
>be No Optout
If any feature is set to block the message will be blocked.
>the code flow should be:
Depending on the settings the code flow should be optimized at any time -
at least the costs for such code are too high for the expected advantage.
Thomas
Von: Michael Thomas <[email protected]>
An: ASSP development mailing list <[email protected]>
Datum: 18.02.2012 09:56
Betreff: [Assp-test] DoBlackRe and BlackRe
Thomas,
My Version: 2.1.2(11356)
Note that I downloaded 2.1.2(12042) and checked the code. For purposes
of this issue, they have essentially the same logic flow in the target
code area.
Note that when set to block, DoBlackRe is supposed to be No Optout.
For sometime, I have wondered why certain email messages were not
blocked. I finally confirmed my suspicion.
The issue is code flow. In sub getbody(), the flow is:
Red check
Whitelisted check
CheckAttachments
BombOK
ScriptOK
BombBlackOK
The issue is that the BombOK check can score the message as spam, but
not block. So, apparently, the BombBlackOK is not executed. I am of the
opinion that at minimum, the code flow should be:
Red check
Whitelisted check
CheckAttachments
BombBlackOK
BombOK
ScriptOK
But, because there is no optout, it probably should be:
BombBlackOK
Red check
Whitelisted check
CheckAttachments
BombOK
ScriptOK
I did not chase down what the flag does, but it also looks like
BombBlackOK sets a flag for SpamLover:
my $slok=$this->{allLoveBoSpam}==1;
Becuase that is the same flag as in BombOK, I am guessing that should
not happen.
I am happy to make those changes and test here, but wanted to get your
opinion first.
--
Michael Thomas
Mathbox
978-687-3300
Toll Free: 1-877-MATHBOX (1-877-628-4269)
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test
DISCLAIMER:
*******************************************************
This email and any files transmitted with it may be confidential, legally
privileged and protected in law and are intended solely for the use of the
individual to whom it is addressed.
This email was multiple times scanned for viruses. There should be no
known virus in this email!
*******************************************************
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Assp-test mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/assp-test
