cc:  [email protected]
Subject: Re: Re: [ast-developers] 2013-02-14 alpha
--------

> I found two bugs (one (IMO bogus) warning) and a valgrind issue
> related to the new "bool" datatype.

I don't see the connection of the one related to the new "bool" datatype
and the valgrind message.  sh_init() is called before the bool
datatype is added to the shell.

Here is a patch for the one related to sh/arith.c. 
==============cut here=================================
*** old/sh/streval.c    Mon Feb  4 15:22:57 2013
--- new/sh/streval.c    Tue Feb 19 10:37:22 2013
***************
*** 159,172 ****
        Math_f fun;
        struct lval node;
        Shell_t *shp = ep->shp;
        node.shp = shp;
        node.emode = ep->emode;
        node.expr = ep->expr;
        node.elen = ep->elen;
-       node.value = 0;
-       node.nosub = 0;
-       node.ptr = 0;
-       node.eflag = 0;
        if(level++ >=MAXLEVEL)
        {
                arith_error(e_recursive,ep->expr,ep->emode);
--- 159,169 ----
        Math_f fun;
        struct lval node;
        Shell_t *shp = ep->shp;
+       memset(&node,0,sizeof(node));
        node.shp = shp;
        node.emode = ep->emode;
        node.expr = ep->expr;
        node.elen = ep->elen;
        if(level++ >=MAXLEVEL)
        {
                arith_error(e_recursive,ep->expr,ep->emode);
==============cut here=================================

David Korn
[email protected]
_______________________________________________
ast-developers mailing list
[email protected]
http://lists.research.att.com/mailman/listinfo/ast-developers

Reply via email to