On Tue, Feb 19, 2013 at 7:47 PM, David Korn <[email protected]> wrote:
> cc: [email protected]
> Subject: Re: Re: [ast-developers] 2013-02-14 alpha
> --------
>
>> I found two bugs (one (IMO bogus) warning) and a valgrind issue
>> related to the new "bool" datatype.
>
> I don't see the connection of the one related to the new "bool" datatype
> and the valgrind message. sh_init() is called before the bool
> datatype is added to the shell.
Erm... I agree... my comment was wrong... I found the issue when
testing the new "bool" datatype (and the example uses it) but it isn't
responsible for the issue... sorry (I didn't dig very deep before
sending the email around) ...
> Here is a patch for the one related to sh/arith.c.
> ==============cut here=================================
> *** old/sh/streval.c Mon Feb 4 15:22:57 2013
> --- new/sh/streval.c Tue Feb 19 10:37:22 2013
> ***************
> *** 159,172 ****
> Math_f fun;
> struct lval node;
> Shell_t *shp = ep->shp;
> node.shp = shp;
> node.emode = ep->emode;
> node.expr = ep->expr;
> node.elen = ep->elen;
> - node.value = 0;
> - node.nosub = 0;
> - node.ptr = 0;
> - node.eflag = 0;
> if(level++ >=MAXLEVEL)
> {
> arith_error(e_recursive,ep->expr,ep->emode);
> --- 159,169 ----
> Math_f fun;
> struct lval node;
> Shell_t *shp = ep->shp;
> + memset(&node,0,sizeof(node));
> node.shp = shp;
> node.emode = ep->emode;
> node.expr = ep->expr;
> node.elen = ep->elen;
> if(level++ >=MAXLEVEL)
> {
> arith_error(e_recursive,ep->expr,ep->emode);
> ==============cut here=================================
Thanks... :-)
... one issue which remains is the "no parent" warning... can you take
a look at that, please ?
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) [email protected]
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
_______________________________________________
ast-developers mailing list
[email protected]
http://lists.research.att.com/mailman/listinfo/ast-developers
