On Mon, Jun 11, 2012 at 4:39 PM, Roland Mainz <[email protected]> wrote: > Hi! > > ---- > > Attached (as "astopen20120606_janitor_statementnotreached001.diff") is > a small cleanup patch which eliminates some of the "statement not > reached" warnings reported by Sun Studio 12.1. AFAIK these changes are > simple&&safe enougth for ksh93u+ ... > > There are a few remaining warnings which require some more thinking: > 1. src/cmd/dsslib/bgp/bgp-mrt.c", line 1721: warning: statement not > reached (E_STATEMENT_NOT_REACHED) > This warning is about this function: > -- snip -- > static int > mrtwrite(Dssfile_t* file, Dssrecord_t* record, Dssdisc_t* disc) > { > ANONYMIZE_WRITE(file, record, disc); > if (disc->errorf) > (*disc->errorf)(NiL, disc, 2, "%s: record write not > implemented", > file->format->name); > return -1; > } > -- snip -- > ... it sounds like that any code beginning with |if (disk->errorf)| is > not executed.. which doesn't sound like this is intended. > > 2. src/cmd/kshlib/dss/dss.c", line 189: warning: statement not reached > (E_STATEMENT_NOT_REACHED) > This is about the following code... I guess there is a |if > (...)|-statement missing: > -- snip -- > data->data = bp->vnode->nvalue; > data->size = nv_size(bp->vnode); > return(1); > if(qp->sel) > -- snip --
Erm... was the patch attached to the original posting applied to the AST codebase ? I haven't checked but I just saw two of these "statement not reached" warnings coming through the log of an active ast-open.2012-06-12 build... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) [email protected] \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) _______________________________________________ ast-developers mailing list [email protected] https://mailman.research.att.com/mailman/listinfo/ast-developers
