clarification: they were patched in a different manner
are they still producing not reached warnings in the same place?
if so
bin/package use
cd dsslib/bgp
nmake -n -g debug.mk bgp-mrt.i
cd kshlib/dss
nmake -n -g debug.mk dss.i
and send me { bgp-mrt.i dss.i } off list
On Thu, 14 Jun 2012 05:59:15 +0200 Roland Mainz wrote:
> --f46d044303ec2686f804c266b9e8
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
> On Thu, Jun 14, 2012 at 5:52 AM, Glenn Fowler <[email protected]> wrote:
> > On Thu, 14 Jun 2012 01:02:34 +0200 Roland Mainz wrote:
> >> On Mon, Jun 11, 2012 at 4:39 PM, Roland Mainz <[email protected]>=
> wrote:
> >> > Attached (as "astopen20120606_janitor_statementnotreached001.diff") is
> >> > a small cleanup patch which eliminates some of the "statement not
> >> > reached" warnings reported by Sun Studio 12.1. AFAIK these changes are
> >> > simple&&safe enougth for ksh93u+ ...
> >> >
> >> > There are a few remaining warnings which require some more thinking:
> >> > 1. src/cmd/dsslib/bgp/bgp-mrt.c", line 1721: warning: statement not
> >> > reached (E_STATEMENT_NOT_REACHED)
> >> > This warning is about this function:
> >> > -- snip --
> >> > static int
> >> > mrtwrite(Dssfile_t* file, Dssrecord_t* record, Dssdisc_t* disc)
> >> > {
> >> > =A0 =A0 =A0 =A0ANONYMIZE_WRITE(file, record, disc);
> >> > =A0 =A0 =A0 =A0if (disc->errorf)
> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(*disc->errorf)(NiL, disc, 2, "%s: reco=
> rd write not implemented",
> >> > file->format->name);
> >> > =A0 =A0 =A0 =A0return -1;
> >> > }
> >> > -- snip --
> >> > ... it sounds like that any code beginning with |if (disk->errorf)| is
> >> > not executed.. which doesn't sound like this is intended.
> >> >
> >> > 2. src/cmd/kshlib/dss/dss.c", line 189: warning: statement not reached
> >> > (E_STATEMENT_NOT_REACHED)
> >> > This is about the following code... I guess there is a |if
> >> > (...)|-statement missing:
> >> > -- snip --
> >> > =A0 =A0 =A0 =A0data->data =3D bp->vnode->nvalue;
> >> > =A0 =A0 =A0 =A0data->size =3D nv_size(bp->vnode);
> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return(1);
> >> > =A0 =A0 =A0 =A0if(qp->sel)
> >> > -- snip --
> >
> >> Erm... was the patch attached to the original posting applied to the
> >> AST codebase ? I haven't checked but I just saw two of these
> >> "statement not reached" warnings coming through the log of an active
> >> ast-open.2012-06-12 build...
> >
> > both of these were patched for 2012-06-12
> Erm... there was a patch attached to that email (I've attached it
> again as "astopen20120606_janitor_statementnotreached001.diff"),
> too...
> ----
> Bye,
> Roland
> --=20
> =A0 __ .=A0 . __
> =A0(o.\ \/ /.o) [email protected]
> =A0 \__\/\/__/=A0 MPEG specialist, C&&JAVA&&Sun&&Unix programmer
> =A0 /O /=3D=3D\ O\=A0 TEL +49 641 3992797
> =A0(;O/ \/ \O;)
> --f46d044303ec2686f804c266b9e8
> Content-Type: text/x-patch; charset=US-ASCII;
> name="astopen20120606_janitor_statementnotreached001.diff"
> Content-Disposition: attachment;
> filename="astopen20120606_janitor_statementnotreached001.diff"
> Content-Transfer-Encoding: base64
> X-Attachment-Id: f_h3fat53s0
> ZGlmZiAtciAtdSBzcmMvY21kLzNkL21rZGlyM2QuYyBzcmMvY21kLzNkL21rZGlyM2QuYwotLS0g
> c3JjL2NtZC8zZC9ta2RpcjNkLmMJU2F0IEFwciAxMCAxMDoyOTowOSAyMDEwCisrKyBzcmMvY21k
> LzNkL21rZGlyM2QuYwlNb24gSnVuIDExIDE1OjU0OjIxIDIwMTIKQEAgLTExMSw4ICsxMTEsNiBA
> QAogCQkJCQllcnJubyA9IG9lcnJubzsKIAkJCQkJcmV0dXJuIC0xOwogCQkJCX0KLQkJCXN0YXRl
> LnBhdGggPSBzYXZlOwotCQkJZXJybm8gPSBvZXJybm87CiAJCX0KIAogCQkvKgpkaWZmIC1yIC11
> IHNyYy9jbWQvZHNzbGliL2JncC9iZ3AtY2lzY28uYyBzcmMvY21kL2Rzc2xpYi9iZ3AvYmdwLWNp
> c2NvLmMKLS0tIHNyYy9jbWQvZHNzbGliL2JncC9iZ3AtY2lzY28uYwlUaHUgQXVnIDExIDA4OjUz
> OjU2IDIwMTEKKysrIHNyYy9jbWQvZHNzbGliL2JncC9iZ3AtY2lzY28uYwlNb24gSnVuIDExIDE1
> OjU0OjUxIDIwMTIKQEAgLTc5LDcgKzc5LDYgQEAKIAkJICAgIGlzZGlnaXQoKmYpICYmICFzdHJ0
> b2lwNChmLCAmdCwgJmFkZHIsICZiaXRzKSAmJiAqdCA9PSAnICcpCiAJCQlyZXR1cm4gMTsKIAl9
> Ci0JcmV0dXJuIDA7CiB9CiAKIC8qCmRpZmYgLXIgLXUgc3JjL2NtZC9kc3NsaWIvYmdwL2JncC1j
> aXNjb3Y2LmMgc3JjL2NtZC9kc3NsaWIvYmdwL2JncC1jaXNjb3Y2LmMKLS0tIHNyYy9jbWQvZHNz
> bGliL2JncC9iZ3AtY2lzY292Ni5jCVRodSBBdWcgMTEgMDg6NTQ6MzIgMjAxMQorKysgc3JjL2Nt
> ZC9kc3NsaWIvYmdwL2JncC1jaXNjb3Y2LmMJTW9uIEp1biAxMSAxNTo1NTozOCAyMDEyCkBAIC04
> MSw3ICs4MSw2IEBACiAJCQlyZXR1cm4gMTsKIAkJfQogCX0KLQlyZXR1cm4gMDsKIH0KIAogLyoK
> ZGlmZiAtciAtdSBzcmMvY21kL2Rzc2xpYi9iZ3AvYmdwLXRhYmxlLmMgc3JjL2NtZC9kc3NsaWIv
> YmdwL2JncC10YWJsZS5jCi0tLSBzcmMvY21kL2Rzc2xpYi9iZ3AvYmdwLXRhYmxlLmMJVGh1IEF1
> ZyAxMSAwODo1ODo0OCAyMDExCisrKyBzcmMvY21kL2Rzc2xpYi9iZ3AvYmdwLXRhYmxlLmMJTW9u
> IEp1biAxMSAxNTo1Njo1MyAyMDEyCkBAIC03Nyw3ICs3Nyw2IEBACiAJCWlmIChpc2RpZ2l0KCpm
> KSAmJiAhc3RydG9pcDQoZiwgTmlMLCAmYWRkciwgJmJpdHMpIHx8ICFzdHJ0b2lwNihmLCBOaUws
> IHByZWZpeCwgcHJlZml4ICsgSVA2QklUUykgJiYgKGZpbGUtPmNhbGxlciA9IGZpbGUpKQogCQkJ
> cmV0dXJuIDE7CiAJfQotCXJldHVybiAwOwogfQogCiAvKgpkaWZmIC1yIC11IHNyYy9jbWQva3No
> OTMvc2gvbmFtZS5jIHNyYy9jbWQva3NoOTMvc2gvbmFtZS5jCi0tLSBzcmMvY21kL2tzaDkzL3No
> L25hbWUuYwlXZWQgSnVuICA2IDE3OjM1OjEwIDIwMTIKKysrIHNyYy9jbWQva3NoOTMvc2gvbmFt
> ZS5jCU1vbiBKdW4gMTEgMTU6NTM6NTQgMjAxMgpAQCAtMTI0NSw3ICsxMjQ1LDYgQEAKIAkJCWNw
> ID0geHA7CiAJCX0KIAl9Ci0JcmV0dXJuKG5wKTsKIH0KIAogLyoKZGlmZiAtciAtdSBzcmMvbGli
> L2xpYnRrc2gvc3JjL3RjbElPLmMgc3JjL2xpYi9saWJ0a3NoL3NyYy90Y2xJTy5jCi0tLSBzcmMv
> bGliL2xpYnRrc2gvc3JjL3RjbElPLmMJV2VkIE1hciAxMiAxODo0NzozMyAyMDAzCisrKyBzcmMv
> bGliL2xpYnRrc2gvc3JjL3RjbElPLmMJTW9uIEp1biAxMSAxNTo1ODoyOSAyMDEyCkBAIC0zNjQy
> LDYgKzM2NDIsOCBAQAogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQorICAgIGNoYW5Q
> dHItPmZsYWdzICY9ICh+KENIQU5ORUxfQkxPQ0tFRCkpOworICAgIHJldHVybiBjb3BpZWQ7CiAj
> ZWxzZQogCWNoYW5TZXRGbGFncyhjaGFuUHRyKTsKIAljaGFuUHRyLT5mbGFncyAmPSAofihDSEFO
> TkVMX0JMT0NLRUQpKTsKQEAgLTM2NDgsOCArMzY1MCw2IEBACiAJY29waWVkID0gc2ZyZWFkKGNo
> YW5QdHItPnNmUHRyLCBidWZQdHIsIHRvUmVhZCk7CiAJcmV0dXJuIGNvcGllZDsKICNlbmRpZgot
> ICAgIGNoYW5QdHItPmZsYWdzICY9ICh+KENIQU5ORUxfQkxPQ0tFRCkpOwotICAgIHJldHVybiBj
> b3BpZWQ7CiB9CiAMCiAvKgpkaWZmIC1yIC11IHNyYy9saWIvbGlidGtzaC9zcmMvdmFyLmMgc3Jj
> L2xpYi9saWJ0a3NoL3NyYy92YXIuYwotLS0gc3JjL2xpYi9saWJ0a3NoL3NyYy92YXIuYwlXZWQg
> SnVsIDIzIDA5OjUzOjQ1IDIwMDgKKysrIHNyYy9saWIvbGlidGtzaC9zcmMvdmFyLmMJTW9uIEp1
> biAxMSAxNTo1Nzo1OCAyMDEyCkBAIC03MDksNyArNzA5LDYgQEAKIAkJbnZfb2ZmYXR0cihudiwg
> TlZfTk9ESVNDKTsgbnZfcmVzdW1lZGlzYyhudik7CiAJCXJldHVybiBudl9nZXR2KG52LCBuZik7
> CiAJfQotCXJldHVybiBOVUxMOwogfQogCiAKZGlmZiAtciAtdSBzcmMvbGliL2xpYnV1L3V1bGli
> LmMgc3JjL2xpYi9saWJ1dS91dWxpYi5jCi0tLSBzcmMvbGliL2xpYnV1L3V1bGliLmMJVGh1IFNl
> cCAyNCAxNjowNjo0NSAyMDA5CisrKyBzcmMvbGliL2xpYnV1L3V1bGliLmMJTW9uIEp1biAxMSAx
> NTo1NDozNiAyMDEyCkBAIC05MTYsNyArOTE2LDYgQEAKIAkJCWJyZWFrOwogCQl9CiAJfQotCXJl
> dHVybiAtMTsKIH0KIAogLyoK
> --f46d044303ec2686f804c266b9e8--
_______________________________________________
ast-developers mailing list
[email protected]
https://mailman.research.att.com/mailman/listinfo/ast-developers
