> On Jan. 20, 2014, 9:08 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/tests.yaml, line 16 > > <https://reviewboard.asterisk.org/r/3132/diff/1/?file=52956#file52956line16> > > > > Thinking for the future: > > > > This is really a test for Offer/Answer - if we configure an endpoint > > with all, do we offer the correct thing? > > > > I'd put this into something like the following: > > > > sdp_offer_answer/nominal/outbound/offer_all > > > > We will, at some point, have off nominal offers sent to Asterisk, and > > have Asterisk deal with offers that contain all (or a lot) of formats. With > > Josh's format work, this is coming up sooner rather than later. > > Scott Griepentrog wrote: > Actually, this particular test is checking inbound, not outbound. But I > do think that outbound testing should be done as well, and I agree it should > be broken out into separate categories as you show. > > Do you want this set up as a new subdirectory pjsip/sdp_offer_answer > instead of merging it into pjsip/basic_calls? >
Yeah, I'd say let's put it into a new sub-directory. We'll have more going in there in the next month or so. > On Jan. 20, 2014, 9:08 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config.yaml, lines > > 16-29 > > <https://reviewboard.asterisk.org/r/3132/diff/1/?file=52955#file52955line16> > > > > I'd prefer not to have all of these tests. > > > > 1. Most of what these tests cover - early media, deferred SDP, various > > transports - is already covered. What we need to test here is that > > configuring and endpoint with "allow=all" results in the correct outbound > > offer - the rest of this behaviour is already tested. > > > > 2. This test already has lots of problems running under Bamboo. It > > fails probably 25% of the time. We shouldn't have put this many SIPp > > scenarios under a single test; I'm guessing that this test will suffer from > > the same problem. > > Scott Griepentrog wrote: > I would have agreed, except that I caught an issue with deferred sdp that > I wouldn't have otherwise. Maybe it would be better to break them out into > smaller groups of tests, such as deferred/ipv4, deferred/ipv6, etc - which > would also help identify which ones are being problematic. I think that'd be fine. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10644 ----------------------------------------------------------- On Jan. 22, 2014, 4:05 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3132/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 4:05 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23018 > https://issues.asterisk.org/jira/browse/ASTERISK-23018 > > > Repository: testsuite > > > Description > ------- > > This is just a copy of > tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host with > allow=all instead of allow=ulaw. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4563 > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3132/diff/ > > > Testing > ------- > > It correctly fails without the 3131 code implemented. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
