----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10663 -----------------------------------------------------------
/asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml <https://reviewboard.asterisk.org/r/3132/#comment20163> This should at least check that a media stream of the expected type was offered. /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml <https://reviewboard.asterisk.org/r/3132/#comment20164> This should check that the SDP response contains the appropriate stream and possibly codec choices as well. /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml <https://reviewboard.asterisk.org/r/3132/#comment20165> Idem. /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml <https://reviewboard.asterisk.org/r/3132/#comment20166> Idem. /asterisk/trunk/tests/channels/pjsip/tests.yaml <https://reviewboard.asterisk.org/r/3132/#comment20154> This patch seems to be missing all the tests.yaml files along the new path specifying subdirectories and tests. - opticron On Jan. 22, 2014, 4:05 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3132/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 4:05 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23018 > https://issues.asterisk.org/jira/browse/ASTERISK-23018 > > > Repository: testsuite > > > Description > ------- > > This is just a copy of > tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host with > allow=all instead of allow=ulaw. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4563 > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/playback_with_deferred_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/sipp/echo_with_deferred_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/ipv4/udp/offer_ulaw_allow_all/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3132/diff/ > > > Testing > ------- > > It correctly fails without the 3131 code implemented. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
