> On Feb. 6, 2014, 10:44 a.m., Matt Jordan wrote: > > /asterisk/trunk/tests/bridge/linkedid_propagation/bridge_action.py, lines > > 3-4 > > <https://reviewboard.asterisk.org/r/3182/diff/2/?file=53430#file53430line3> > > > > I didn't write this :-) > > > > Or... maybe I did? > > > > If so, and multiple tests need to use this logic, there's no need to > > copy it. In fact, having duplicate copies of what drives the same test > > isn't needed. There are two ways to handle this: > > > > (1) Add the linkedid propagation verification to the existing test. > > This is probably preferable, if what drives the test is exactly the same as > > another test. > > > > (2) If there are differences between the Asterisk actions that drive > > the test, then refactor the common code into a shared module. You have two > > choices on where to put that shared module: > > (a) In lib/python/asterisk > > (b) In a Python module in a base directory. The YAML for defining > > pluggable modules lets you specify search paths for modules, which you can > > then specify to the location of the module.
I pulled a copy of bridge_action.py into linkedid_propgation test dir as-is. However, I agree that the linkedid check can just be added to the existing bridge_action tests - posting that as an update. - Scott ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3182/#review10782 ----------------------------------------------------------- On Feb. 10, 2014, 2:37 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3182/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 2:37 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23120 > https://issues.asterisk.org/jira/browse/ASTERISK-23120 > > > Repository: testsuite > > > Description > ------- > > This monitors bridge enter/exit and CEL events, and builds > a picture of which channels are bridged together, and when > their LinkedID changes, and then verifies that each change > is correct. > > Note: The BridgeEnter and CEL 'BRIDGE_ENTER' events can be > in either order - so wait for both to arrive before making > a judgement on the LinkedID. > > This test can be added to any other bridging test to add a > layer of LinkedId Propagation checking to it. > > This test has now been added to the existing bridge_action > test rather than have a separate test for it. > > > Diffs > ----- > > /asterisk/trunk/tests/bridge/bridge_action/test-config.yaml 4675 > /asterisk/trunk/tests/bridge/bridge_action/bridge_action.py 4675 > /asterisk/trunk/lib/python/asterisk/linkedid_check.py PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3182/diff/ > > > Testing > ------- > > This test fails spuriously due to what appears to be CEL events being sent on > BRIDGE_ENTER prior to the LinkedId being updated. This bug will be fixed > along with the other changes for 23120. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
