----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3182/#review10883 -----------------------------------------------------------
Ship it! This looks good. Just the two minor nitpicks below. /asterisk/trunk/lib/python/asterisk/linkedid_check.py <https://reviewboard.asterisk.org/r/3182/#comment20499> This is unnecessary. /asterisk/trunk/lib/python/asterisk/linkedid_check.py <https://reviewboard.asterisk.org/r/3182/#comment20500> .addCallback(self.getvar_callback).addErrback(self.getvar_failback) can be combined into: .addCallbacks(self.getvar_callback, self.getvar_failback) - opticron On Feb. 10, 2014, 2:37 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3182/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 2:37 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23120 > https://issues.asterisk.org/jira/browse/ASTERISK-23120 > > > Repository: testsuite > > > Description > ------- > > This monitors bridge enter/exit and CEL events, and builds > a picture of which channels are bridged together, and when > their LinkedID changes, and then verifies that each change > is correct. > > Note: The BridgeEnter and CEL 'BRIDGE_ENTER' events can be > in either order - so wait for both to arrive before making > a judgement on the LinkedID. > > This test can be added to any other bridging test to add a > layer of LinkedId Propagation checking to it. > > This test has now been added to the existing bridge_action > test rather than have a separate test for it. > > > Diffs > ----- > > /asterisk/trunk/tests/bridge/bridge_action/test-config.yaml 4675 > /asterisk/trunk/tests/bridge/bridge_action/bridge_action.py 4675 > /asterisk/trunk/lib/python/asterisk/linkedid_check.py PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3182/diff/ > > > Testing > ------- > > This test fails spuriously due to what appears to be CEL events being sent on > BRIDGE_ENTER prior to the LinkedId being updated. This bug will be fixed > along with the other changes for 23120. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
