-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3240/#review10915
-----------------------------------------------------------



asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test
<https://reviewboard.asterisk.org/r/3240/#comment20541>

    I recommend using AMI SetVar here instead. The big reason is that it allows 
for you to set the presence state, subtype, and message so you can check that 
all three show up in the NOTIFY sent from Asterisk.



asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml
<https://reviewboard.asterisk.org/r/3240/#comment20540>

    Typically, the way to escape quotation marks in XML is to use &quot; 
instead of \". If &quot; still allows the scenario to pass, then I recommend 
switching to that notation.


- Mark Michelson


On Feb. 19, 2014, 10:38 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3240/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 10:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test for presence for digium phones.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml 4726 
>   
> asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/test-config.yaml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml
>  PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test 
> PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/pjsip.conf
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/extensions.conf
>  PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3240/diff/
> 
> 
> Testing
> -------
> 
> Ran test and it passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to