> On Feb. 20, 2014, 5:38 p.m., Mark Michelson wrote: > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test, > > lines 39-40 > > <https://reviewboard.asterisk.org/r/3240/diff/1/?file=54248#file54248line39> > > > > I recommend using AMI SetVar here instead. The big reason is that it > > allows for you to set the presence state, subtype, and message so you can > > check that all three show up in the NOTIFY sent from Asterisk.
Actually the CLI command allows you to specify subtype and message as well in a comma separated list, so I will just add it as such. > On Feb. 20, 2014, 5:38 p.m., Mark Michelson wrote: > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml, > > line 28 > > <https://reviewboard.asterisk.org/r/3240/diff/1/?file=54249#file54249line28> > > > > Typically, the way to escape quotation marks in XML is to use " > > instead of \". If " still allows the scenario to pass, then I > > recommend switching to that notation. Since this is actually specifying the regex escaping the quotes works fine. Also I couldn't use '"' as it would then translate the '&' to '&' while attempting to match and then raise an error on mismatch since it was expecting '"' and not '&quot;'. Might be able to escape the '&', but that puts us back to where we started :-) - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3240/#review10915 ----------------------------------------------------------- On Feb. 19, 2014, 4:38 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3240/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 4:38 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > Test for presence for digium phones. > > > Diffs > ----- > > asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml 4726 > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/test-config.yaml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml > PRE-CREATION > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/pjsip.conf > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3240/diff/ > > > Testing > ------- > > Ran test and it passed. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
