----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11180 -----------------------------------------------------------
Ship it! Short of protecting the global interfaces container pointer with ao2_global_obj which can be expensive CPU wise or leaking it on shutdown there is no way to completely prevent a crash from a NULL interfaces pointer. All this patch can do is minimize the chance of a crash. /branches/11/main/format.c <https://reviewboard.asterisk.org/r/3209/#comment20821> Nit. Please put a blank line after every variable declaration section to separate variable declaration from normal code. - rmudgett On March 13, 2014, 12:37 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3209/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 12:37 p.m.) > > > Review request for Asterisk Developers, Corey Farrell and n8ideas. > > > Bugs: ASTERISK-23103 > https://issues.asterisk.org/jira/browse/ASTERISK-23103 > > > Repository: Asterisk > > > Description > ------- > > Alternate method to more safely shutdown interfaces container. Set interface > global to null first to avoid possible race condition, and also double check > interfaces prior to all uses. > > > Diffs > ----- > > /branches/11/main/format.c 410525 > > Diff: https://reviewboard.asterisk.org/r/3209/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
