----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11181 -----------------------------------------------------------
/branches/11/main/format.c <https://reviewboard.asterisk.org/r/3209/#comment20824> I think this condition still needs !ast_undestroyed_channels(). If we have undestroyed channels then find_interface will be called many times per second. format_attr_shutdown could free interfaces after find_interface has already checked it, allowing ao2_find on either an already freed or NULL pointer. - Corey Farrell On March 13, 2014, 1:37 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3209/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:37 p.m.) > > > Review request for Asterisk Developers, Corey Farrell and n8ideas. > > > Bugs: ASTERISK-23103 > https://issues.asterisk.org/jira/browse/ASTERISK-23103 > > > Repository: Asterisk > > > Description > ------- > > Alternate method to more safely shutdown interfaces container. Set interface > global to null first to avoid possible race condition, and also double check > interfaces prior to all uses. > > > Diffs > ----- > > /branches/11/main/format.c 410525 > > Diff: https://reviewboard.asterisk.org/r/3209/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
