----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3516/#review11805 -----------------------------------------------------------
/team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21641> Looking at this, should AST_MEDIA_TYPE_UNKNOWN really be AST_MEDIA_TYPE_ALL? /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21642> Commented out. I know we haven't done the RTP layer yet, hence why we don't have the ability to put packetization in - but we'll need a note to come back and here and snag this. Maybe a BUGBUG? :-) /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21643> On the wiki page, make a note that we need to have a chan_sip test for SIP_CODEC*. I know we don't have one yet, and after this we'll really, really, really want one. /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21644> To not require all the unlocking, you could alloc this on the assignment and check that it allocated successfully before creating tmp. /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21645> How does this choose the best audio format? /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21646> Add one for prefcaps /team/group/media_formats-reviewed/channels/chan_sip.c <https://reviewboard.asterisk.org/r/3516/#comment21647> Put a BUGBUG comment or something similar here. - Matt Jordan On April 30, 2014, 5:50 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3516/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 5:50 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change moves chan_sip over to the new media formats work. > > > Diffs > ----- > > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413144 > /team/group/media_formats-reviewed/channels/sip/include/sip.h 413144 > /team/group/media_formats-reviewed/channels/chan_sip.c 413144 > > Diff: https://reviewboard.asterisk.org/r/3516/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
