> On May 1, 2014, 7:46 p.m., Matt Jordan wrote: > > /team/group/media_formats-reviewed/channels/chan_sip.c, line 6094 > > <https://reviewboard.asterisk.org/r/3516/diff/1/?file=58175#file58175line6094> > > > > Looking at this, should AST_MEDIA_TYPE_UNKNOWN really be > > AST_MEDIA_TYPE_ALL?
I've wrestled with this myself. I went with unknown because media type is used in a few different ways - like the above where I intended it to be a "I don't know what I want and don't care". Other cases it's "I don't know the type but I know this other information". - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3516/#review11805 ----------------------------------------------------------- On May 11, 2014, 12:46 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3516/ > ----------------------------------------------------------- > > (Updated May 11, 2014, 12:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change moves chan_sip over to the new media formats work. > > > Diffs > ----- > > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413652 > /team/group/media_formats-reviewed/channels/sip/include/sip.h 413300 > /team/group/media_formats-reviewed/channels/chan_sip.c 413300 > > Diff: https://reviewboard.asterisk.org/r/3516/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
