----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review12007 -----------------------------------------------------------
Yay for tests! (And the other changes look good. You still have my ship-it for when you're done.) trunk/tests/test_uri.c <https://reviewboard.asterisk.org/r/3541/#comment21944> Rather verbose, to have one test per uri. And at the same time you don't test the NULL values. I'd trim this file down to a single ast_uri_parse-test function and use a nice array, similar to this: char *scenarios[] = { {"http://name:pass@localhost";, "http", "name:pass", "localhost", NULL, NULL, NULL}, {"http://localhost";, "http", NULL, "localhost", NULL, NULL, NULL}, ... - wdoekes On May 29, 2014, 9:14 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3541/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 9:14 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Bugs: ASTERISK-23742 > https://issues.asterisk.org/jira/browse/ASTERISK-23742 > > > Repository: Asterisk > > > Description > ------- > > Add client websocket capabilities to Asterisk. > > > Diffs > ----- > > trunk/tests/test_websocket_client.c PRE-CREATION > trunk/tests/test_uri.c PRE-CREATION > trunk/res/res_http_websocket.exports.in 414813 > trunk/res/res_http_websocket.c 414813 > trunk/main/uri.c PRE-CREATION > trunk/main/http.c 414813 > trunk/include/asterisk/uri.h PRE-CREATION > trunk/include/asterisk/http_websocket.h 414813 > trunk/include/asterisk/http.h 414813 > > Diff: https://reviewboard.asterisk.org/r/3541/diff/ > > > Testing > ------- > > Created some unit tests. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
