----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review12031 -----------------------------------------------------------
Ship it! Other than the minor nit below, LGTM. trunk/tests/test_uri.c <https://reviewboard.asterisk.org/r/3541/#comment21975> Should be 'const char'. The values are in RO mem. - wdoekes On June 2, 2014, 3:57 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3541/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 3:57 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Bugs: ASTERISK-23742 > https://issues.asterisk.org/jira/browse/ASTERISK-23742 > > > Repository: Asterisk > > > Description > ------- > > Add client websocket capabilities to Asterisk. > > > Diffs > ----- > > trunk/tests/test_websocket_client.c PRE-CREATION > trunk/tests/test_uri.c PRE-CREATION > trunk/res/res_http_websocket.exports.in 414813 > trunk/res/res_http_websocket.c 414813 > trunk/main/uri.c PRE-CREATION > trunk/main/http.c 414813 > trunk/include/asterisk/uri.h PRE-CREATION > trunk/include/asterisk/http_websocket.h 414813 > trunk/include/asterisk/http.h 414813 > > Diff: https://reviewboard.asterisk.org/r/3541/diff/ > > > Testing > ------- > > Created some unit tests. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
