----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3582/#review12037 -----------------------------------------------------------
/branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3582/#comment21979> I've had to do all of this extra checking here which I don't think is completely accurate. When I just had this outside of the if statement then user would return false if they weren't wait marked and also weren't muted. - Andrew Nagy On June 3, 2014, 1:06 p.m., Andrew Nagy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3582/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 1:06 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > In confbridge when attempting to mute a user who is WaitMarked for Leader > wait the message from the CLI comes back as "No channel named > 'PJSIP/1000-00000015' found in conference 4000" which is confusing because > the channel is in the conference it's just not in the active list. > > My proposed solution is the patch attached to this file where I return a > message to both the CLI and the AMI if the user is wait marked. > > > Diffs > ----- > > /branches/12/apps/app_confbridge.c 415059 > > Diff: https://reviewboard.asterisk.org/r/3582/diff/ > > > Testing > ------- > > Tested Adding marked users and attempting to mute them, then tested with an > invalid channel and finally tested that regular muting still worked. > > > Thanks, > > Andrew Nagy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
